Adaptive Toolbar: Set background color for Side Swipe on incognito NTP |
|||||||
Issue descriptionDuring side swipe on the toolbar (to change tab), a snapshot of the toolbar is displayed for each tab being changed. When swiping from/to incognito NTP tabs, the appearance of the toolbar should match the NTP's one, regarding the background color. Assigning to Rohit as you are working on the incognito NTP for the new UI. This bug is for tracking purpose (TODO).
,
Jan 23 2018
Please add the user story label here.
,
Jan 23 2018
Please also add the size of this task: small, medium, or large?
,
Jan 24 2018
,
Jan 26 2018
,
Jan 27 2018
,
May 9 2018
,
May 25 2018
pschaffner@ can you point to the spec here?
,
May 25 2018
I think this bug is about the NTP toolbar disappearing when you switch tabs via the toolbar side-swipe gesture, but I'm not sure based off of the description. Justin is aware of the disappearing toolbar issue I just described and is opening a new issue assigned to him to fix. Closing this issue in favor of his, but please re-open if I've misunderstood.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dc4043d02659d0966bc936e67f3c72e9eeff89c commit 9dc4043d02659d0966bc936e67f3c72e9eeff89c Author: Justin Cohen <justincohen@google.com> Date: Thu May 31 17:45:53 2018 [ios] Remove unused incognito NTP toolbar methods and comments. Bug: 803379 , 804850 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I27d18de9a813cf4a333d6330d42e314b4f124989 Reviewed-on: https://chromium-review.googlesource.com/1080249 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563304} [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/ntp/new_tab_page_controller_delegate.h [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/9dc4043d02659d0966bc936e67f3c72e9eeff89c/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gambard@chromium.org
, Jan 23 2018