Issue 804847 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	mlippautz@chromium.org
Closed:	Jan 2018
Cc:	estevenson@chromium.org
Components:	Blink>MemoryAllocator>GarbageCollection
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug-Regression
Performance-Size M-66

116.5 KiB regression in resource_sizes (MonochromePublic.apk) at 531203:531203

Project Member Reported by estevenson@chromium.org, Jan 23 2018

Issue description

Caused by "[oilpan] Extract visitor from marker"

Commit: bf779fc562b95cc6a65b3f5a045f2777f97232af

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=531203

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: All native code growth.

Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=804847

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9799a9597f236ef7dba884fff888a5e86a67fede1bd3f4adf36b769fe2fac31b


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by estevenson@chromium.org, Jan 23 2018

Labels: OS-Android
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

See the attached symbol diff for more details.

diff_results.txt
2.2 MB View Download

Comment 3 by raphael....@intel.com, Jan 23 2018

Components: Blink>MemoryAllocator>GarbageCollection

Comment 4 by mlippautz@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)

This has been reverted for other reasons. I will check the sizes befor relanding a new (different) version.

►

Issue 804847 link

Issue metadata

116.5 KiB regression in resource_sizes (MonochromePublic.apk) at 531203:531203

Issue description

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

Comment 1 Deleted

Comment 2 by estevenson@chromium.org, Jan 23 2018

Comment 2 Deleted

Comment 3 by raphael....@intel.com, Jan 23 2018

Comment 3 Deleted

Comment 4 by mlippautz@chromium.org, Jan 30 2018

Comment 4 Deleted

Sign in to add a comment