Connecting to Node.js causes DevTools to crash. |
||
Issue descriptionSteps to repro: 1) run Node.js LTS (8.9.4) as follows: node --inspect-brk -e "" 2) build and start tip-of-tree Chrome (66.0.3330.0, d665c92a8aac55d966283bb1db1007b586bcf8d6) with following GN args: use_goma = true dcheck_always_on = true is_component_build = false symbol_level = 1 is_debug = false 3) open DevTools 4) click on the Node.js logo 5) observe crash [98106:98106:0123/140509.047769:FATAL:devtools_session.cc(135)] Check failed: !browser_only_. #0 0x55bbe18248fc base::debug::StackTrace::StackTrace() #1 0x55bbe1844e73 logging::LogMessage::~LogMessage() #2 0x55bbdfe293b8 content::DevToolsSession::DispatchProtocolMessage() #3 0x55bbdfe18579 content::DevToolsAgentHostImpl::DispatchProtocolMessage() #4 0x55bbe3aa5dfe DevToolsUIBindings::DispatchProtocolMessageFromDevToolsFrontend() #5 0x55bbe3acab4a _ZN12_GLOBAL__N_114ParseAndHandleIJRKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEEEEbRKN4base17RepeatingCallbackIFvDpT_EEERKNSB_IFvPKNSA_5ValueEEEERKNSA_9ListValueE #6 0x55bbe3aca788 DispatcherImpl::Dispatch() #7 0x55bbe3aa1930 DevToolsUIBindings::HandleMessageFromDevToolsFrontend() #8 0x55bbe030f7f6 content::DevToolsFrontendHostImpl::DispatchEmbedderMessage() #9 0x55bbdfaa25d2 blink::mojom::DevToolsFrontendHostStubDispatch::Accept() #10 0x55bbe20f2e77 mojo::InterfaceEndpointClient::HandleValidatedMessage() #11 0x55bbe20f57f6 mojo::FilterChain::Accept() #12 0x55bbe20f4342 mojo::InterfaceEndpointClient::HandleIncomingMessage() #13 0x55bbe2152ec2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread() #14 0x55bbe2150c81 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #15 0x55bbe182653a base::debug::TaskAnnotator::RunTask() #16 0x55bbe184c886 base::internal::IncomingTaskQueue::RunTask() #17 0x55bbe184acb7 base::MessageLoop::RunTask() #18 0x55bbe184b0d4 base::MessageLoop::DeferOrRunPendingTask() #19 0x55bbe184b398 base::MessageLoop::DoWork() #20 0x55bbe184f68f base::(anonymous namespace)::WorkSourceDispatch() #21 0x7f5e0c48a7f7 g_main_context_dispatch #22 0x7f5e0c48aa60 <unknown> #23 0x7f5e0c48ab0c g_main_context_iteration #24 0x55bbe184f442 base::MessagePumpGlib::Run() #25 0x55bbe184a50c base::MessageLoop::Run() #26 0x55bbe187b056 base::RunLoop::Run() #27 0x55bbe14a3c97 ChromeBrowserMainParts::MainMessageLoopRun() #28 0x55bbdfdbc7e7 content::BrowserMainLoop::RunMainMessageLoopParts() #29 0x55bbdfdc0223 content::BrowserMainRunnerImpl::Run() #30 0x55bbdfdb85ca content::BrowserMain() #31 0x55bbe147325b content::RunNamedProcessTypeMain() #32 0x55bbe14741b7 content::ContentMainRunnerImpl::Run() #33 0x55bbe14810b4 service_manager::Main() #34 0x55bbe1472681 content::ContentMain() #35 0x55bbdf3651cd ChromeMain #36 0x7f5e086192b1 __libc_start_main #37 0x55bbdf36502a _start Received signal 6 #0 0x55bbe18248fc base::debug::StackTrace::StackTrace() #1 0x55bbe18243d1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f5e0e5770c0 <unknown> #3 0x7f5e0862bfcf gsignal #4 0x7f5e0862d3fa abort #5 0x55bbe1823375 base::debug::BreakDebugger() #6 0x55bbe18452a4 logging::LogMessage::~LogMessage() #7 0x55bbdfe293b8 content::DevToolsSession::DispatchProtocolMessage() #8 0x55bbdfe18579 content::DevToolsAgentHostImpl::DispatchProtocolMessage() #9 0x55bbe3aa5dfe DevToolsUIBindings::DispatchProtocolMessageFromDevToolsFrontend() #10 0x55bbe3acab4a _ZN12_GLOBAL__N_114ParseAndHandleIJRKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEEEEbRKN4base17RepeatingCallbackIFvDpT_EEERKNSB_IFvPKNSA_5ValueEEEERKNSA_9ListValueE #11 0x55bbe3aca788 DispatcherImpl::Dispatch() #12 0x55bbe3aa1930 DevToolsUIBindings::HandleMessageFromDevToolsFrontend() #13 0x55bbe030f7f6 content::DevToolsFrontendHostImpl::DispatchEmbedderMessage() #14 0x55bbdfaa25d2 blink::mojom::DevToolsFrontendHostStubDispatch::Accept() #15 0x55bbe20f2e77 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x55bbe20f57f6 mojo::FilterChain::Accept() #17 0x55bbe20f4342 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x55bbe2152ec2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread() #19 0x55bbe2150c81 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #20 0x55bbe182653a base::debug::TaskAnnotator::RunTask() #21 0x55bbe184c886 base::internal::IncomingTaskQueue::RunTask() #22 0x55bbe184acb7 base::MessageLoop::RunTask() #23 0x55bbe184b0d4 base::MessageLoop::DeferOrRunPendingTask() #24 0x55bbe184b398 base::MessageLoop::DoWork() #25 0x55bbe184f68f base::(anonymous namespace)::WorkSourceDispatch() #26 0x7f5e0c48a7f7 g_main_context_dispatch #27 0x7f5e0c48aa60 <unknown> #28 0x7f5e0c48ab0c g_main_context_iteration #29 0x55bbe184f442 base::MessagePumpGlib::Run() #30 0x55bbe184a50c base::MessageLoop::Run() #31 0x55bbe187b056 base::RunLoop::Run() #32 0x55bbe14a3c97 ChromeBrowserMainParts::MainMessageLoopRun() #33 0x55bbdfdbc7e7 content::BrowserMainLoop::RunMainMessageLoopParts() #34 0x55bbdfdc0223 content::BrowserMainRunnerImpl::Run() #35 0x55bbdfdb85ca content::BrowserMain() #36 0x55bbe147325b content::RunNamedProcessTypeMain() #37 0x55bbe14741b7 content::ContentMainRunnerImpl::Run() #38 0x55bbe14810b4 service_manager::Main() #39 0x55bbe1472681 content::ContentMain() #40 0x55bbdf3651cd ChromeMain #41 0x7f5e086192b1 __libc_start_main #42 0x55bbdf36502a _start r8: 0000000000000000 r9: 00007ffcabbd53d0 r10: 0000000000000008 r11: 0000000000000246 r12: 00007ffcabbd5b20 r13: 000000000000005e r14: 00007ffcabbd5b28 r15: 00007ffcabbd5669 di: 0000000000000002 si: 00007ffcabbd53d0 bp: 00007ffcabbd5610 bx: 0000000000000006 dx: 0000000000000000 ax: 0000000000000000 cx: 00007f5e0862bfcf sp: 00007ffcabbd5448 ip: 00007f5e0862bfcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated.
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15858fdce57a918f05b17fca4de690f0cc5bc2ad commit 15858fdce57a918f05b17fca4de690f0cc5bc2ad Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Jan 23 19:57:34 2018 [DevTools] do not fall through in target domain in browser only mode R=dgozman@chromium.org Bug: chromium:804845 Change-Id: I37ae5ec7e32954bd32cb8e58683e864cd76938c8 Reviewed-on: https://chromium-review.googlesource.com/881462 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531316} [modify] https://crrev.com/15858fdce57a918f05b17fca4de690f0cc5bc2ad/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/15858fdce57a918f05b17fca4de690f0cc5bc2ad/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/15858fdce57a918f05b17fca4de690f0cc5bc2ad/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/15858fdce57a918f05b17fca4de690f0cc5bc2ad/content/browser/devtools/render_frame_devtools_agent_host.cc
,
Jan 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by kozy@chromium.org
, Jan 23 2018Owner: kozy@chromium.org
Status: Assigned (was: Untriaged)