New issue
Advanced search Search tips

Issue 804836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 804247
issue 753850



Sign in to add a comment

HangoutServicesBrowserTest.RunComponentExtensionTest DCHECK failure

Project Member Reported by michae...@chromium.org, Jan 23 2018

Issue description

Running HangoutServicesBrowserTest.RunComponentExtensionTest on my checkout hits a DCHECK failure in WebrtcAudioPrivateGetAssociatedSinkFunction::CalculateHMACOnIOThread():

[163789:163819:0123/042328.237725:FATAL:webrtc_audio_private_api.cc(285)] Check failed: !raw_sink_id || !raw_sink_id->empty().

The test passes after commenting out the DCHECK. Happens with is_chrome_branded = true, or with just enable_hangout_services_extension = true.

Full output below.


% ./out_linux/rel/browser_tests --gtest_filter=HangoutServicesBrowserTest.RunComponentExtensionTest
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = HangoutServicesBrowserTest.RunComponentExtensionTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from HangoutServicesBrowserTest, where TypeParam =
[ RUN      ] HangoutServicesBrowserTest.RunComponentExtensionTest
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
[163789:163831:0123/042325.874696:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[163789:163789:0123/042325.891006:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.

(browser_tests:163789): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:'
[163789:163914:0123/042327.517783:WARNING:simple_synchronous_entry.cc(1173)] Could not open platform files for entry.
[163789:163914:0123/042327.647680:WARNING:simple_synchronous_entry.cc(1173)] Could not open platform files for entry.
[163789:163917:0123/042327.786817:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
[163789:163789:0123/042328.007921:INFO:CONSOLE(172)] "Starting testCpuGetInfo", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.033162:INFO:CONSOLE(202)] "Got results for testCpuGetInfo: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.033697:INFO:CONSOLE(172)] "Starting testLogging", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.086063:INFO:CONSOLE(202)] "Got results for testLogging: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.086611:INFO:CONSOLE(172)] "Starting testLoggingSetMetaDataAfterStart", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.115670:INFO:CONSOLE(202)] "Got results for testLoggingSetMetaDataAfterStart: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.116217:INFO:CONSOLE(172)] "Starting testDisabledLogging", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.133542:INFO:CONSOLE(202)] "Got results for testDisabledLogging: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.134043:INFO:CONSOLE(172)] "Starting testDisabledLoggingButUpload", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.160122:INFO:CONSOLE(202)] "Got results for testDisabledLoggingButUpload: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.160627:INFO:CONSOLE(172)] "Starting testDisabledLoggingWithStopAndUpload", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.196367:INFO:CONSOLE(202)] "Got results for testDisabledLoggingWithStopAndUpload: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.196805:INFO:CONSOLE(172)] "Starting testEnabledLoggingButDiscard", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.225797:INFO:CONSOLE(202)] "Got results for testEnabledLoggingButDiscard: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.226186:INFO:CONSOLE(172)] "Starting testGetSinks", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163789:0123/042328.233305:INFO:CONSOLE(202)] "Got results for testGetSinks: ", source: http://localhost:46708/extensions/hangout_services_test.js (202)
[163789:163789:0123/042328.233686:INFO:CONSOLE(172)] "Starting testGetAssociatedSink", source: http://localhost:46708/extensions/hangout_services_test.js (172)
[163789:163819:0123/042328.237725:FATAL:webrtc_audio_private_api.cc(285)] Check failed: !raw_sink_id || !raw_sink_id->empty().
#0 0x7f072c5aa3ec base::debug::StackTrace::StackTrace()
#1 0x7f072c5d4dbc logging::LogMessage::~LogMessage()
#2 0x0000034c9a07 extensions::WebrtcAudioPrivateGetAssociatedSinkFunction::CalculateHMACOnIOThread()
#3 0x0000034c9852 extensions::WebrtcAudioPrivateGetAssociatedSinkFunction::ReceiveInputDeviceDescriptionsOnIOThread()
#4 0x0000034ca5f8 _ZN4base8internal13FunctorTraitsIMN10extensions34WebrtcAudioPrivateGetSinksFunctionEFvNSt3__16vectorIN5media22AudioDeviceDescriptionENS4_9allocatorIS7_EEEEEvE6InvokeI13scoped_refptrIS3_EJSA_EEEvSC_OT_DpOT0_
#5 0x7f0727238ea8 _ZN4base8internal13FunctorTraitsINS_12OnceCallbackIFvNSt3__16vectorIN5media22AudioDeviceDescriptionENS3_9allocatorIS6_EEEEEEEvE6InvokeISB_JS9_EEEvOT_DpOT0_
#6 0x7f072c5ab34a base::debug::TaskAnnotator::RunTask()
#7 0x7f072c5de796 base::internal::IncomingTaskQueue::RunTask()
#8 0x7f072c5e2a77 base::MessageLoop::RunTask()
#9 0x7f072c5e2e94 base::MessageLoop::DeferOrRunPendingTask()
#10 0x7f072c5e3158 base::MessageLoop::DoWork()
#11 0x7f072c5e5f69 base::MessagePumpLibevent::Run()
#12 0x7f072c5e22cc base::MessageLoop::Run()
#13 0x7f072c619f36 base::RunLoop::Run()
#14 0x7f072c65e13a base::Thread::Run()
#15 0x7f0728996228 content::BrowserThreadImpl::IOThreadRun()
#16 0x7f0728996441 content::BrowserThreadImpl::Run()
#17 0x7f072c65e733 base::Thread::ThreadMain()
#18 0x7f072c6548ef base::(anonymous namespace)::ThreadFunc()
#19 0x7f072c6f8184 start_thread
#20 0x7f071f7cf03d clone

[0123/042328.546838:ERROR:kill_posix.cc(84)] Unable to terminate process group 163789: No such process (3)
[1/1] HangoutServicesBrowserTest.RunComponentExtensionTest (CRASHED)
1 test crashed:
    HangoutServicesBrowserTest.RunComponentExtensionTest (../../chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc:248)
(
 
Owner: grunell@chromium.org
Status: Assigned (was: Untriaged)
Labels: OS-Chrome OS-Mac OS-Windows
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b9a96089772adef7f6fc7dc118a291520864d4

commit 43b9a96089772adef7f6fc7dc118a291520864d4
Author: Henrik Grunell <grunell@chromium.org>
Date: Wed Jan 24 21:13:25 2018

Use base::nullopt instead of std::string() for Optional parameter in WebrtcAudioPrivateGetAssociatedSinkFunction.

DCHECK was hit because of incorrect usage; fixed with this change.

Bug:  804836 
Change-Id: Ia09f9a6bc563b6468236fd821ade49e1cb8f0fa7
Reviewed-on: https://chromium-review.googlesource.com/883343
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531685}
[modify] https://crrev.com/43b9a96089772adef7f6fc7dc118a291520864d4/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Status: Fixed (was: Assigned)

Sign in to add a comment