New issue
Advanced search Search tips

Issue 804813 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Failed Test: set-rootscroller-before-load.html layout

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 23 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@google.com

set-rootscroller-before-load.html layout test fails repeatedly in site_per_process_webkit_layout_tests failing on chromium.linux/Linux Tests.

Builders failed on: 
- Linux Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests

Latest Failures:
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/66653
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/66652
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/66651

 
Cc: robertma@chromium.org
Description: Show this description
Cc: -robertma@chromium.org
Owner: flackr@chromium.org
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
Hi Robert,

I reverted the CL as it had consecutive failures.
Labels: Sheriff-Chromium
Summary: Failed Test: set-rootscroller-before-load.html layout test fails (was: Tests fail repeatedly in site_per_process_webkit_layout_tests failing on chromium.linux/Linux Tests)
Summary: Failed Test: set-rootscroller-before-load.html layout (was: Failed Test: set-rootscroller-before-load.html layout test fails )
Labels: -Sheriff-Chromium
Untagging sheriff-chromium, since the failures aren't happening after the revert in #4.
Components: Blink>Scroll
Labels: -Pri-2 Pri-1
FYI, it seems there are multiple causes at play here, since this flaked again after the revert had landed: <https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/66683>

The failure is:
02:18:25.222 8731 [1/1] virtual/android/rootscroller/set-rootscroller-before-load.html failed unexpectedly (reference mismatch)
02:18:25.222 8731 worker/0 virtual/android/rootscroller/set-rootscroller-before-load.html failed:
02:18:25.222 8731 worker/0  reference mismatch

flackr@: please take a peek :)
Cc: bokan@chromium.org
+bokan who added the test.

Right, maybe this wasn't my patch. Do you know how to test site_per_process_webkit_layout_tests locally? It's not a build target and I'm not quite sure where to get the command to run tests from the swarming bot output.

Comment 12 by bokan@chromium.org, Jan 25 2018

Xianzhu recently deflaked some other rootscroller tests. I've got a patch that'll hopefully do the same for this test: https://chromium-review.googlesource.com/c/chromium/src/+/886561
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee14a915fc62a2bf108143ead0b0e0e46aea335

commit 5ee14a915fc62a2bf108143ead0b0e0e46aea335
Author: David Bokan <bokan@chromium.org>
Date: Thu Jan 25 18:00:19 2018

Deflake set-rootscroller-before-load.html

Additional test to chcanges landed in r531871

Bug:  804813 
Change-Id: I9684318423e2e00ee20a4f5504e0420ecf8d080c
Reviewed-on: https://chromium-review.googlesource.com/886561
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531938}
[modify] https://crrev.com/5ee14a915fc62a2bf108143ead0b0e0e46aea335/third_party/WebKit/LayoutTests/rootscroller/set-rootscroller-before-load.html

Comment 14 by bokan@chromium.org, Jan 25 2018

My patch is landed - you could give it another try and see if that helped.

Comment 15 by bokan@chromium.org, Mar 22 2018

Status: WontFix (was: Assigned)
Flakiness dashboard shows all green so closing this out.

Sign in to add a comment