New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804811 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

cc_perftests failing on Android

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 23 2018

Issue description

Owner: danakj@chromium.org
Status: Assigned (was: Available)
Strongly suspecting this change: https://chromium.googlesource.com/chromium/src/+/4e871d8fb606cb411e2883be013479bddbc37837 due to raster_buffer_provider_perf_test changes.

Dana, could you take a look? 

I'll kick off a bisect to get a confirmation in the meanwhile.
Btw the failing tests are:

C  614.285s Main  [  FAILED  ] 5 tests, listed below:
C  614.285s Main  [  FAILED  ] RasterBufferProviderCommonPerfTest.BuildTileTaskGraph (CRASHED)
C  614.285s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/0 (UNKNOWN)
C  614.285s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/1 (UNKNOWN)
C  614.285s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/2 (UNKNOWN)
C  614.285s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/3 (UNKNOWN)

Comment 4 by danakj@chromium.org, Jan 23 2018

Cc: vmp...@chromium.org
Status: Started (was: Assigned)

Comment 5 by danakj@chromium.org, Jan 23 2018

Cc: ashleymarie@google.com huayinz@chromium.org ccameron@chromium.org twelling...@chromium.org enne@chromium.org mpear...@chromium.org
 Issue 803874  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46425f31b192c629b09b6bf4141f8f831dff981f

commit 46425f31b192c629b09b6bf4141f8f831dff981f
Author: danakj <danakj@chromium.org>
Date: Tue Jan 23 18:35:32 2018

Fix and re-enable cc perf tests on Android.

These tests were DCHECKing from either failing to complete tasks
and thus not returning ResourcePool resources to the pool, or from
completing tasks multiple times (after doing a test-only "Reset" on
the tasks) and thus returning ResourcePool resources multiple times,
both of which are invalid.

R=vmpstr@chromium.org

Bug:  804811 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia88217295551787a1e52725c21ec2ce5bee0c091
Reviewed-on: https://chromium-review.googlesource.com/881303
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531284}
[modify] https://crrev.com/46425f31b192c629b09b6bf4141f8f831dff981f/cc/raster/raster_buffer_provider_perftest.cc

Comment 7 by danakj@chromium.org, Jan 23 2018

Status: Fixed (was: Started)

Sign in to add a comment