New issue
Advanced search Search tips

Issue 804809 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

[Remote suggestions] Display whether the last fetch was authenticated in snippets-internals page

Project Member Reported by jkrcal@chromium.org, Jan 23 2018

Issue description

This info is useful for debugging.
 
This will help the refactoring of the Identity service (lead by Collin) to avoid regressions.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b9f66da4f2e956bbab655aef376c298a29db52

commit 60b9f66da4f2e956bbab655aef376c298a29db52
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Jan 29 14:45:58 2018

[chrome://snippets-internals] Show if the last fetch was authenticated

The CL reveals the info whether the last fetch was authenticated or not
via chrome://snippets-internals.

The CL also does a minor polish of the internals page (only to be able
to display the new field in a logical place.

Bug:  804809 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I040ad1b6c223e8ab7c2a0893a820dcc014fbcdba
Reviewed-on: https://chromium-review.googlesource.com/880862
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532424}
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/components/ntp_snippets/remote/remote_suggestions_fetcher.h
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h
[modify] https://crrev.com/60b9f66da4f2e956bbab655aef376c298a29db52/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

Thank you!

Comment 4 by zea@chromium.org, Jan 30 2018

Labels: zine-triaged
L

Comment 5 by jkrcal@chromium.org, Jan 31 2018

Status: Fixed (was: Started)

Sign in to add a comment