Issue metadata
Sign in to add a comment
|
Bubble pop-up is not destroyed after copied to clip tray
Reported by
lge-systemwebview@lge.com,
Jan 23 2018
|
||||||||||||||||||||
Issue descriptionTHIS TEMPLATE IS FOR FILING BUGS ON THE ANDROID SYSTEM WEBVIEW. GENERAL WEB BUGS SHOULD BE FILED USING A DIFFERENT TEMPLATE! Device name: LG G6, SAMSUNG S8 Android version: 7.0/8.0 WebView version (from system settings -> Apps -> Android System WebView): 63.0.3239.111 Application: LGEmail app using WebView Application version: 6.85.12 URLs (if applicable): Precondition: Configure an account. Steps to reproduce: (1) Launch LGEmail Composer, place cursor in Editor body. (2) Option Menu > Insert > Image (3) Long press on image (Bubble pop-up is displayed with Cut, Copy, Select All etc.) (4) Click on Copy option. (5) Image copied to clip tray, toast shown and observe. Expected result: Bubble pop-up should be dismissed. Actual result: Bubble pop-up is not dismissed after copy is done. Note: Issue not reproduced on WebView version: 60.0.3112.116 and it is reproduced on WebView version: 61.0.3163.98 onwards.
,
Jan 24 2018
,
Jan 24 2018
Tested the issue in WebView and able to reproduce the issue. Steps Followed: (1) Launched LGEmail Composer, placed cursor in Editor body. (2) Option Menu inserted image (3) Long pressed on image (Bubble pop-up is displayed with Cut, Copy, Select All etc.) (4) Clicked on Copy option. (5) Image copied to clip tray, toast shown (6) Observed Bubble pop-up is not dismissed after copy is done Webview tested: 64.0.3282.116, 63.0.3239.111 OS: Android 6.0.1 Android Devices: LG G5 Below are the manual bisect info Good build: 62.0.3169.0 Bad build: 62.0.3170.0 Please navigate to below link for log's and video-- go/chrome-androidlogs/804792 Requesting MTV team to work on tool bisect for this issue Thanks!!
,
Jan 24 2018
This looks similar to issue 794877, but this regressed in M62, not M64. amaralp@, could you take a look?
,
Feb 1 2018
I don't know how LG implements their floating menu so this is a guess but I think they are overriding Chrome's ActionMode. To fix this problem they should call ActionMode#finish() in ActionMode.Callback#onActionItemClicked() if copy was clicked.
,
Feb 13 2018
Sorry for the late reply. 1. We are overriding WebView's ActionMode. 2. Till previous chrome versions(i.e. versions which mentioned in the issue description), when selection is cleared even bubble popup was getting dismissed(in case of cut, copy). Hence We were not calling finish(). Cut - calling 'delete' executeCommand, popup is dismissed Copy - Once copy is done, we are removing the selection range to clear the selection. When text+image is selected, bubble popup is dismissed but if it is only image, issue observed. 3. Same issue is reproduced(i.e select just image) with IME back key also. ContentEditable editor -> insert image and select just image -> press delete key in IME -> observe popup is not dismissed. For point 2, we can call finish() from app side. Please check point 3. Thank you. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lge-systemwebview@lge.com
, Jan 23 201810.4 MB
10.4 MB View Download