New issue
Advanced search Search tips

Issue 804788 link

Starred by 1 user
Status: Fixed
Owner:
justincohen@chromium.org
Closed: May 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 1
Type: Task
Q2

Blocked on:
issue 831978


Sign in to add a comment

TabStrip: Change the background the non-active tab and background (solid)

Project Member Reported by gambard@chromium.org, Jan 23 2018 
See description

Comment 1 by gambard@chromium.org, Jan 25 2018

Summary: TabStrip: Change the background the non-active tab and background (solid) (was: Tools and Navigation Menu: Change the background the non-active tab and background (solid))

Comment 2 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 3 by gambard@chromium.org, Jan 26 2018

Labels: -medium small

Comment 4 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 5 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 9 2018 

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by cmasso@google.com, Apr 9 2018

Owner: justincohen@chromium.org

Comment 8 by cmasso@google.com, Apr 11 2018

Labels: -Pri-0 Pri-1

Comment 9 by mard...@chromium.org, Apr 12 2018

Blockedon: 831978

Comment 10 Deleted

Comment 11 by justincohen@chromium.org, May 1 2018

Status: Started (was: arE)

Comment 12 by justincohen@chromium.org, May 2 2018

NextAction: 2018-05-09
Project Member

Comment 13 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839fc677647379a36046da82dcad7a41b11ec7fb

commit 839fc677647379a36046da82dcad7a41b11ec7fb
Author: Justin Cohen <justincohen@google.com>
Date: Mon May 07 19:27:12 2018

[ios] Refresh images for tab strip.

Updates tab strip foreground and background images, new tab image and close
image.  Also removes blur in toolbar for RxR trait.

Bug: 831978,  804787 ,  804788 ,  804786 ,  804789 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia93c08ede9dd40f6a72311aa40b275fc896e402a
Reviewed-on: https://chromium-review.googlesource.com/1042107
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556526}
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/BUILD.gn
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button.imageset/tabswitcher_tab_switcher_count_button.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button.imageset/tabswitcher_tab_switcher_count_button@2x.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button_pressed.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button_pressed.imageset/tabswitcher_tab_switcher_count_button_pressed.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tab_switcher/resources/tabswitcher_tab_switcher_count_button_pressed.imageset/tabswitcher_tab_switcher_count_button_pressed@2x.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/BUILD.gn
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab.imageset/tabstrip_background_tab@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab.imageset/tabstrip_background_tab~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab_legacy.imageset/tabstrip_background_tab_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_background_tab_legacy.imageset/tabstrip_background_tab_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab.imageset/tabstrip_foreground_tab@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab.imageset/tabstrip_foreground_tab~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab_legacy.imageset/tabstrip_foreground_tab_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_foreground_tab_legacy.imageset/tabstrip_foreground_tab_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab.imageset/tabstrip_incognito_background_tab@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab.imageset/tabstrip_incognito_background_tab~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab_legacy.imageset/tabstrip_incognito_background_tab_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_background_tab_legacy.imageset/tabstrip_incognito_background_tab_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab.imageset/tabstrip_incognito_foreground_tab@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab.imageset/tabstrip_incognito_foreground_tab~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab_legacy.imageset/tabstrip_incognito_foreground_tab_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_incognito_foreground_tab_legacy.imageset/tabstrip_incognito_foreground_tab_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab.imageset/tabstrip_new_tab@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab.imageset/tabstrip_new_tab~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito.imageset/tabstrip_new_tab_incognito@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito.imageset/tabstrip_new_tab_incognito~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_legacy.imageset/tabstrip_new_tab_incognito_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_legacy.imageset/tabstrip_new_tab_incognito_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed.imageset/tabstrip_new_tab_incognito_pressed@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed.imageset/tabstrip_new_tab_incognito_pressed~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed_legacy.imageset/tabstrip_new_tab_incognito_pressed_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_incognito_pressed_legacy.imageset/tabstrip_new_tab_incognito_pressed_legacy~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_legacy.imageset/tabstrip_new_tab_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_legacy.imageset/tabstrip_new_tab_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed.imageset/tabstrip_new_tab_pressed@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed.imageset/tabstrip_new_tab_pressed~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed_legacy.imageset/tabstrip_new_tab_pressed_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_new_tab_pressed_legacy.imageset/tabstrip_new_tab_pressed_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close.imageset/tabstrip_tab_close@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close.imageset/tabstrip_tab_close~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito.imageset/tabstrip_tab_close_incognito@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito.imageset/tabstrip_tab_close_incognito~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_legacy.imageset/tabstrip_tab_close_incognito_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_legacy.imageset/tabstrip_tab_close_incognito_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed.imageset/tabstrip_tab_close_incognito_pressed@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed.imageset/tabstrip_tab_close_incognito_pressed~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed_legacy.imageset/tabstrip_tab_close_incognito_pressed_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_incognito_pressed_legacy.imageset/tabstrip_tab_close_incognito_pressed_legacy~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_legacy.imageset/tabstrip_tab_close_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_legacy.imageset/tabstrip_tab_close_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed.imageset/tabstrip_tab_close_pressed@2x~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed.imageset/tabstrip_tab_close_pressed~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed_legacy.imageset/Contents.json
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed_legacy.imageset/tabstrip_tab_close_pressed_legacy@2x~ipad.png
[add] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/resources/tabstrip_tab_close_pressed_legacy.imageset/tabstrip_tab_close_pressed_legacy~ipad.png
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/839fc677647379a36046da82dcad7a41b11ec7fb/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm

Comment 14 by justincohen@chromium.org, May 9 2018

Status: Fixed (was: Started)
Marking fixed for non-blur work.

Comment 15 by monor...@bugs.chromium.org, May 9 2018 

The NextAction date has arrived: 2018-05-09
►

Sign in to add a comment