New issue
Advanced search Search tips

Issue 804780 link

Starred by 1 user
Status: Verified
Owner:
justincohen@chromium.org
Closed: May 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 1
Type: Task
Q2

Blocked on:
issue 804781
issue 804782
issue 804783


Sign in to add a comment

TabStrip: Add the action to display the menu and display it

Project Member Reported by gambard@chromium.org, Jan 23 2018 
See description

Comment 1 by gambard@chromium.org, Jan 23 2018

Labels: -S-Tab-Strip S-Tab-Strip-Action

Comment 2 by gambard@chromium.org, Jan 25 2018

Summary: TabStrip: Add the action to display the menu and display it (was: Tools and Navigation Menu: Add the action to display the menu and display it)

Comment 3 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 4 by gambard@chromium.org, Jan 26 2018

Blockedon: 804781 804782 804783
Labels: -medium small

Comment 5 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 6 by cmasso@google.com, Apr 5 2018

Labels: Pri-0

Comment 7 by cmasso@google.com, Apr 5 2018

Labels: Pri-1

Comment 8 by cmasso@google.com, Apr 9 2018

Owner: justincohen@chromium.org

Comment 9 by justincohen@chromium.org, May 9 2018

NextAction: 2018-05-23
Status: Started (was: Assigned)

Comment 10 by monor...@bugs.chromium.org, May 23 2018 

The NextAction date has arrived: 2018-05-23
Project Member

Comment 11 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc282dd10327794ebe7336f032a4bb168e405bc

commit acc282dd10327794ebe7336f032a4bb168e405bc
Author: Justin Cohen <justincohen@google.com>
Date: Tue May 29 14:23:28 2018

[ios] Add tab strip tab grid button long press popup for refresh.

Adds new tab, new incognito, and close tab to long press.

Bug:  804783 ,  804782 ,  804781 ,  804780 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I847f3a5b873c14585673702672a7094ef53c328e
Reviewed-on: https://chromium-review.googlesource.com/1048594
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562415}
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/commands/popup_menu_commands.h
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_updating.h
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/util/layout_guide_names.h
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/ios/chrome/browser/ui/util/layout_guide_names.mm
[modify] https://crrev.com/acc282dd10327794ebe7336f032a4bb168e405bc/tools/metrics/actions/actions.xml

Comment 12 by justincohen@chromium.org, May 29 2018

Status: Fixed (was: Started)

Comment 13 by shbarezer@chromium.org, Jun 5 2018

Status: Verified (was: Fixed)
Verified in 69.0.3449.0 Canary, iPhone X iOS11.4, iPhone 6 iOS10.3.3, iPhone 7 iOS12.0 iPad Air iOS11.3.1
►

Sign in to add a comment