New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804778 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Tools and Navigation Menu: Update the default favicon on the menus

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Cc: gambard@chromium.org
Labels: -medium small
Owner: pschaffner@chromium.org
Assign to pschaffner@: Please provide the icon.

Comment 4 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-1
Labels: Proj-UIRefresh
Cc: martijnb@chromium.org
For the history menu cells, use the same cell metrics as those used in the tools and tab switcher menus (see here: https://bugs.chromium.org/p/chromium/issues/detail?id=817795#c5), with these exceptions: 

- menu item text color: black
- cell height: 44pt; trailing-edge truncation with ellipsis; single-line
- cell icon background rect: 28x28pt; black @ 3%; 7pt corner radius;
- cell icon favicon: 16x16pt favicon centered vertically+horizontally on top of the background rect; 2pt corner radius; clips to bounds; transparent background

NOTE: I'm waiting on confirmation from the design team for the correct favicon fallback glyph to use. You can use our current in the meantime.

Mock for reference: https://drive.google.com/open?id=13RK2ulgPh5Dxj6Uq6RRBjezNKci_aXqE&authuser=pschaffner@google.com
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08faa2656aa23693416784920e8ddb8e9619cd0d

commit 08faa2656aa23693416784920e8ddb8e9619cd0d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Apr 24 13:31:31 2018

Adjust navigation history menu visual

This CL adjusts the navigation menu items to look like the mocks.

Bug:  804778 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3d4b45196207e98187af64cac25a6d7cf7309f90
Reviewed-on: https://chromium-review.googlesource.com/1025752
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553071}
[modify] https://crrev.com/08faa2656aa23693416784920e8ddb8e9619cd0d/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm

Verified in 68.0.3416.0 Canary, iPhone X iOS 11.4 beta 2, iPhone 6 iOS 10.3.3, iPhone 7 iOS11.4 beta 2, iPad Pro iOS11.3

https://drive.google.com/file/d/1Yzypv4wPubK6j4fCnsQ9gazcHGhHZtmn/view
NextAction: 2018-05-09
Status: Verified (was: Assigned)
Discussed offline, keeping the current icon for now.
The NextAction date has arrived: 2018-05-09

Sign in to add a comment