New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804773 link

Starred by 2 users
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2018
Cc:
sczs@chromium.org
gambard@chromium.org
█ lod@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Popup Menu: Create the tools menu items with the correct show/hide enable/disable states

Project Member Reported by gambard@chromium.org, Jan 23 2018 
See description

Comment 1 by marq@chromium.org, Jan 29 2018

Owner: lod@chromium.org

Comment 2 by marq@chromium.org, Mar 9 2018

Owner: gambard@chromium.org

Comment 3 by gambard@chromium.org, Mar 14 2018

Summary: Popup Menu: Update the tools menu content style and add dividers (was: Tools and Navigation Menu: Update the tools menu content style and add dividers)

Comment 4 by gambard@chromium.org, Mar 14 2018

Labels: -medium large
Might be broken down if needed.

Comment 5 by gambard@chromium.org, Mar 21 2018

Cc: gambard@chromium.org sczs@chromium.org
 Issue 823879  has been merged into this issue.

Comment 6 by gambard@chromium.org, Mar 21 2018

Labels: Bijou-user-study
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9448b41ada7082eefcce4d1a01360b9ac78ffcf2

commit 9448b41ada7082eefcce4d1a01360b9ac78ffcf2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Mar 21 08:21:46 2018

Create the items for the tools menu

This CL creates the items to be used by the tools menu.
It also creates the actions associated with the items.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id34c8fb33daceaa34276aa4c42cf39ce0d3a5eb1
Reviewed-on: https://chromium-review.googlesource.com/970583
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544655}
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn
[add] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_item.h
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/9448b41ada7082eefcce4d1a01360b9ac78ffcf2/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm

Comment 8 by marq@chromium.org, Mar 21 2018

Labels: -Bijou-user-study UI-refresh-user-study

Comment 9 by gambard@chromium.org, Mar 21 2018

Summary: Popup Menu: Create the tools menu items with the correct show/hide enable/disable states (was: Popup Menu: Update the tools menu content style and add dividers)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989466e9a9d3ad2af49d956fed4d6f3c4421f79f

commit 989466e9a9d3ad2af49d956fed4d6f3c4421f79f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 13:57:42 2018

Have the PopupMenu mediator observing WebState

This CL changes the PopupMenuMediator to have it observing the WebState
and updating the PopupMenuViewController accordingly.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I63f84598a09899fe250825a028250756d9480bdc
Reviewed-on: https://chromium-review.googlesource.com/975125
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545423}
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/cells/popup_menu_item.h
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[add] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
[modify] https://crrev.com/989466e9a9d3ad2af49d956fed4d6f3c4421f79f/ios/chrome/test/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37d5f9ac428b39f0bd006b5952d441eee3edb268

commit 37d5f9ac428b39f0bd006b5952d441eee3edb268
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 14:01:58 2018

Update the items of the tools menu

This CL updates the items of the tools menu, enabling/disabling them
based on the current page status.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I51303d71c88873a0183fcf343a03c5eeca2f3096
Reviewed-on: https://chromium-review.googlesource.com/975605
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545426}
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/37d5f9ac428b39f0bd006b5952d441eee3edb268/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36664eb429a6dbe6e8e487c025409fdee445c304

commit 36664eb429a6dbe6e8e487c025409fdee445c304
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 14:05:32 2018

Add showSettings and ReportIssue actions to ToolsMenu

This CL wires the Show Settings and Report an Issue actions of the
tools menu to the tools menu.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5dd1c36731732630e30dc756d2396b448ce22e48
Reviewed-on: https://chromium-review.googlesource.com/975607
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545428}
[modify] https://crrev.com/36664eb429a6dbe6e8e487c025409fdee445c304/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/36664eb429a6dbe6e8e487c025409fdee445c304/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/36664eb429a6dbe6e8e487c025409fdee445c304/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/195b544df0e822ed10bfe5675d24ce7e766f116d

commit 195b544df0e822ed10bfe5675d24ce7e766f116d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 14:23:57 2018

Dismiss the tools menu on app backgrounding

This CL dismisses the popup menus when the app is backgrounded.
It also fixes the TabGrid
-viewWillTransitionToSize:withTransitionCoordinator: by calling super,
allowing the call to be propagated to other ViewController.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id14f3da62253e333cfaa6aede0b025e08e1ea303
Reviewed-on: https://chromium-review.googlesource.com/975551
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545433}
[modify] https://crrev.com/195b544df0e822ed10bfe5675d24ce7e766f116d/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/195b544df0e822ed10bfe5675d24ce7e766f116d/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 14 by gambard@chromium.org, Mar 26 2018

Labels: -large medium
NextAction: 2018-03-28
Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae4116449954321627295b1cdf15089aa20b757

commit bae4116449954321627295b1cdf15089aa20b757
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 27 07:30:40 2018

Add the accessibility IDs to tools menu items

This CL adds accessibility identifiers to all the items in the tools
menu.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifaa40d7174dadf16e71a49949d5f674f873ff8b3
Reviewed-on: https://chromium-review.googlesource.com/980552
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546051}
[modify] https://crrev.com/bae4116449954321627295b1cdf15089aa20b757/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/bae4116449954321627295b1cdf15089aa20b757/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/bae4116449954321627295b1cdf15089aa20b757/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.h
[modify] https://crrev.com/bae4116449954321627295b1cdf15089aa20b757/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.mm
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db354a32680d7a2a37aa3d76757da5e1abb3d862

commit db354a32680d7a2a37aa3d76757da5e1abb3d862
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 27 09:13:34 2018

Add section separator for the tools menu

This CL adds a section separator for the tools menu, displayed as an
item with a grey line in the middle.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I70d783ee0db85b8889dda5bbbe0d8ab2714a04a6
Reviewed-on: https://chromium-review.googlesource.com/977911
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546070}
[modify] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn
[add] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/cells/popup_menu_footer_item.h
[add] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/cells/popup_menu_footer_item.mm
[modify] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/db354a32680d7a2a37aa3d76757da5e1abb3d862/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm

Comment 17 by monor...@bugs.chromium.org, Mar 28 2018 

The NextAction date has arrived: 2018-03-28
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5a6984aebeafd361830070212ff99eefbcfa07

commit 7a5a6984aebeafd361830070212ff99eefbcfa07
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Mar 28 15:22:21 2018

Add last actions to the tools menu

This CL adds the missing actions (ReadLater/SiteInformation) to the
tools menu.

Bug:  804773 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia28894abcabae8d267094953ff95e440c42300ba
Reviewed-on: https://chromium-review.googlesource.com/980314
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546489}
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/7a5a6984aebeafd361830070212ff99eefbcfa07/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
►

Sign in to add a comment