New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Popup Menu: Add logic to the presenter to dismiss on outside taps

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by marq@chromium.org, Jan 29 2018

Owner: lod@chromium.org

Comment 2 by lod@chromium.org, Feb 20 2018

NextAction: 2018-02-28
The NextAction date has arrived: 2018-02-28

Comment 4 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14

Comment 5 by marq@chromium.org, Mar 9 2018

Owner: gambard@chromium.org
The NextAction date has arrived: 2018-03-14
NextAction: 2018-03-28
Status: Started (was: Assigned)
Labels: -medium small
Summary: Popup Menu: Add logic to the presenter to dismiss on outside taps (was: Tools and Navigation Menu: Add logic to the presentation controller to dismiss on outside taps)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd

commit 86ab60eb9f4dd63985c1194a3a34e8c35d0145dd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 20 13:16:14 2018

Add coordinator for the popup menu

This CL adds a coordinator for the popup menu. This coordinator is in
charge of handling all "showPopupX" events.
This coordinator is aimed to replace all the other coordinator currently
handling those event, like the toolsMenuCoordinator or the
TabHistoryCoordinator and their associated protocols.

Bug:  804770 ,  804771 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib206abed3c22bf64b023b9cd55a7fe11a7372ccd
Reviewed-on: https://chromium-review.googlesource.com/962454
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544341}
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/history_popup_commands.h
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/popup_menu_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/tools_menu_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/history_popup/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/buttons/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/tools_menu/tools_menu_coordinator.h

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment