New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804770 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2018
Cc:
█ lod@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Popup Menu: Create the underlying architecture for presenting the tools menu

Project Member Reported by gambard@chromium.org, Jan 23 2018 
See description

Comment 1 by marq@chromium.org, Jan 29 2018

Owner: lod@chromium.org

Comment 2 by lod@chromium.org, Feb 15 2018

Status: Started (was: Assigned)

Comment 3 by lod@chromium.org, Feb 20 2018

NextAction: 2018-02-28

Comment 4 by monor...@bugs.chromium.org, Feb 28 2018 

The NextAction date has arrived: 2018-02-28

Comment 5 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14

Comment 6 by marq@chromium.org, Mar 9 2018

Owner: gambard@chromium.org

Comment 7 by monor...@bugs.chromium.org, Mar 14 2018 

The NextAction date has arrived: 2018-03-14

Comment 8 by gambard@chromium.org, Mar 14 2018

Summary: Popup Menu: Create the underlying architecture for presenting the tools menu (was: Tools and Navigation Menu: Update tools menu presentation to use the presentation controller and a transition coordinator.)
This is for creating the base classes and their interactions with the rest of the app.

Comment 9 by gambard@chromium.org, Mar 14 2018

NextAction: 2018-03-28
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2746a4b13ba03c2dae0be264b32e185903ddb307

commit 2746a4b13ba03c2dae0be264b32e185903ddb307
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 20 12:52:16 2018

Presentation for popup menu

This CL creates the first files used to present the popup menu.
The presenter is used to display a view inside a popup, with a scrim
on the rest of the screen, preventing interactions.
It also creates a flag to enable it, as we don't want to use the general
phase 1 flag while the tools menu is not working.

For now this presenter is not used anywhere.

Bug:  804770 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3015e8aeb063dd948f8bf1cdb8d15667093345ae
Reviewed-on: https://chromium-review.googlesource.com/962444
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544338}
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/OWNERS
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_flags.h
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_flags.mm
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.h
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.h
[add] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.h
[modify] https://crrev.com/2746a4b13ba03c2dae0be264b32e185903ddb307/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd

commit 86ab60eb9f4dd63985c1194a3a34e8c35d0145dd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 20 13:16:14 2018

Add coordinator for the popup menu

This CL adds a coordinator for the popup menu. This coordinator is in
charge of handling all "showPopupX" events.
This coordinator is aimed to replace all the other coordinator currently
handling those event, like the toolsMenuCoordinator or the
TabHistoryCoordinator and their associated protocols.

Bug:  804770 ,  804771 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib206abed3c22bf64b023b9cd55a7fe11a7372ccd
Reviewed-on: https://chromium-review.googlesource.com/962454
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544341}
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/history_popup_commands.h
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/popup_menu_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/commands/tools_menu_commands.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/history_popup/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[add] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.h
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/buttons/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/86ab60eb9f4dd63985c1194a3a34e8c35d0145dd/ios/chrome/browser/ui/tools_menu/tools_menu_coordinator.h
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7050b8e8ce0d27e821b1450723fb69eeca76e2d7

commit 7050b8e8ce0d27e821b1450723fb69eeca76e2d7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 20 14:55:34 2018

Create table view for the popup menu

This CL creates a table view used to display the elements of the popup
menus and the items to be presented by this table view.
It also creates the mediator used to create and manage the items.

Bug:  804770 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc861cc1d8d2c37bdc3d5dc70f2b072d657dd721
Reviewed-on: https://chromium-review.googlesource.com/966201
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544365}
[modify] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[modify] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[add] https://crrev.com/7050b8e8ce0d27e821b1450723fb69eeca76e2d7/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfda94d7857e8627d957a84768252520e2885158

commit dfda94d7857e8627d957a84768252520e2885158
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Mar 22 07:37:58 2018

Add missing metrics to the tools menu

This CL adds the metrics for the new tools menu actions.

Bug:  804770 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic39f8043906b7c5db2cd6ed390a6afbcf5f5037c
Reviewed-on: https://chromium-review.googlesource.com/973601
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545004}
[modify] https://crrev.com/dfda94d7857e8627d957a84768252520e2885158/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/dfda94d7857e8627d957a84768252520e2885158/tools/metrics/actions/actions.xml
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05b557c79196961d4e6bd435299aaca4a4d3c9be

commit 05b557c79196961d4e6bd435299aaca4a4d3c9be
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 23 14:19:10 2018

Merge newToolsMenu into UIRefresh flag

This CL merges the flag for the new toolsMenu into the general UI
refresh flag.
When opening the tools menu, the new UI should be displayed.

Bug:  804770 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9a289cfaf30d9ae27dfb80ac3380ebed23455b08
Reviewed-on: https://chromium-review.googlesource.com/975563
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545432}
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.h
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h
[modify] https://crrev.com/05b557c79196961d4e6bd435299aaca4a4d3c9be/ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h

Comment 15 by gambard@chromium.org, Mar 26 2018

Status: Fixed (was: Started)

Comment 16 by monor...@bugs.chromium.org, Mar 28 2018 

The NextAction date has arrived: 2018-03-28
►

Sign in to add a comment