New issue
Advanced search Search tips

Issue 804760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 832661



Sign in to add a comment

Adaptive Toolbar: Update the tips anchor point such as it is pointing in the right direction relatively to the button

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
Summary: Adaptive Toolbar: Update the tips anchor point such as it is pointing in the right direction relatively to the button (was: Adaptive Toolbar: Update the tips anchor point such as it is pointing in the right direction relatively to the button position in the app, changing with the size class (for now the tips are always shown below and on the left of the anchor point).)
The position can be changing with the size class (for now the tips are always shown below and on the left of the anchor point).

Comment 2 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 3 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 4 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 832661

Comment 7 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-04-25
The NextAction date has arrived: 2018-04-25
NextAction: 2018-05-09
Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc333162313ae2cc4c6b1f3bf0ef955aa8e58b3

commit 1dc333162313ae2cc4c6b1f3bf0ef955aa8e58b3
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed May 02 09:39:31 2018

Change bubble arrow direction based on toolbar state

This CL changes the direction of the arrow pointing from the bubble
tip to its anchor based on the toolbar mode (split or unsplit) when
the UI Refresh is enabled.

Bug:  804760 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8de0cb833004c646fd7578d6421aa4dbe0810c0f
Reviewed-on: https://chromium-review.googlesource.com/1015022
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555334}
[modify] https://crrev.com/1dc333162313ae2cc4c6b1f3bf0ef955aa8e58b3/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-05-09

Sign in to add a comment