New issue
Advanced search Search tips

Issue 804750 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocking:
issue 804748



Sign in to add a comment

Adaptive Toolbar: Make the cancel button appear

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2
Blocking: 804748

Comment 3 by cmasso@google.com, Jan 26 2018

Labels: -Q2

Comment 4 by cmasso@google.com, Jan 26 2018

Labels: -Q1 Q2

Comment 5 by cma...@chromium.org, Jan 31 2018

Labels: -Q2 Q1
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f902809c6d7bd82dbb266654feacc1c73d1373e

commit 6f902809c6d7bd82dbb266654feacc1c73d1373e
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Feb 01 16:55:52 2018

Add cancel button for location bar edit

This CL adds a cancel button to stop editing the location bar.
It also adds the appearance/disappearance animation.

Bug:  804750 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibb9723fe3df94e1f43b332116128518c309b817b
Reviewed-on: https://chromium-review.googlesource.com/897364
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533703}
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.mm
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/6f902809c6d7bd82dbb266654feacc1c73d1373e/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm

Status: Fixed (was: Assigned)

Sign in to add a comment