New issue
Advanced search Search tips

Issue 804749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocking:
issue 804748



Sign in to add a comment

Adaptive Toolbar: Expand the location bar

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2
Labels: -medium small
Blocking: 804748

Comment 4 by cmasso@google.com, Jan 26 2018

Labels: -Q2

Comment 5 by cmasso@google.com, Jan 26 2018

Labels: -Q1 Q2

Comment 6 by cma...@chromium.org, Jan 31 2018

Labels: -Q2 Q1
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b83b425b9ee162a3adeed3663ead2d692cd1ff

commit e3b83b425b9ee162a3adeed3663ead2d692cd1ff
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Feb 02 15:33:35 2018

Update the animations when focusing the omnibox

This CL changes the animations when focusing the omnibox to expand the
location bar to take the full width of the screen and hide the buttons.

Bug:  804751 ,  804749 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71653dddb10323a55f660f4b9432b3ec112584b7
Reviewed-on: https://chromium-review.googlesource.com/899146
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534056}
[modify] https://crrev.com/e3b83b425b9ee162a3adeed3663ead2d692cd1ff/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.mm
[modify] https://crrev.com/e3b83b425b9ee162a3adeed3663ead2d692cd1ff/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/e3b83b425b9ee162a3adeed3663ead2d692cd1ff/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/e3b83b425b9ee162a3adeed3663ead2d692cd1ff/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h
[modify] https://crrev.com/e3b83b425b9ee162a3adeed3663ead2d692cd1ff/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm

Status: Fixed (was: Assigned)

Sign in to add a comment