New issue
Advanced search Search tips

Issue 804748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804749
issue 804750
issue 804751



Sign in to add a comment

Adaptive Toolbar: Build the animation

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
Cc: gambard@chromium.org
 Issue 801082  has been merged into this issue.

Comment 2 by cma...@chromium.org, Jan 26 2018

Labels: Q2
Blockedon: 804749 804750 804751
Labels: -medium small

Comment 4 by cmasso@google.com, Jan 26 2018

Labels: -Q2

Comment 5 by cmasso@google.com, Jan 26 2018

Labels: -Q1 Q2

Comment 6 by cma...@chromium.org, Jan 31 2018

Labels: -Q2 Q1
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3724a2a9d3e065522c18cc39757e0cf4756ddc90

commit 3724a2a9d3e065522c18cc39757e0cf4756ddc90
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Feb 01 16:13:59 2018

Add orchestrator for the omnibox focus animation

This CL adds an orchestrator for the animation triggered when the
omnibox is focused. This orchestrator is responsible for coordinating
the animation occuring in multiple stages and through multiple object.

Having one central object ensure all animations are occuring with the
same timing.

Bug:  804748 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I07583f0fabde6b2fea8c0f9b2a7830fbb7e3cbc8
Reviewed-on: https://chromium-review.googlesource.com/895443
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533686}
[add] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/orchestrator/BUILD.gn
[add] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/orchestrator/OWNERS
[add] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.h
[add] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.mm
[add] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/orchestrator/toolbar_animatee.h
[modify] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.h
[modify] https://crrev.com/3724a2a9d3e065522c18cc39757e0cf4756ddc90/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3

commit 19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Feb 15 07:25:04 2018

Add util for the split toolbar mode

This CL adds an util to know when the toolbar is split.

Bug:  804748 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7d6accb32de848ff2b3e0ff8aef68d7c278aeb9a
Reviewed-on: https://chromium-review.googlesource.com/916194
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536961}
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/history/history_panel_view_controller.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/history/history_search_view.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/page_info/page_info_view_controller.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/tabs/tab_strip_egtest.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/ui/uikit_ui_util.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/browser/web/navigation_egtest.mm
[modify] https://crrev.com/19c98807f6b75b1a0bdc8baa6abcdf1592d6c1a3/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64559eae06975e9574e0967a27c795a1d2bdaf00

commit 64559eae06975e9574e0967a27c795a1d2bdaf00
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Feb 16 08:53:50 2018

Show toolbar buttons after omnibox resized

This CL changes the animations of the toolbar when the omnibox is
unfocused. The buttons are now appearing after the omnibox is resized.

Bug:  804748 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I149a004f4aa9e8d643ad2cc6d88de95855a66f83
Reviewed-on: https://chromium-review.googlesource.com/922102
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537260}
[modify] https://crrev.com/64559eae06975e9574e0967a27c795a1d2bdaf00/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.mm

Status: Fixed (was: Assigned)

Sign in to add a comment