New issue
Advanced search Search tips

Issue 804747 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Add integration tests

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
NextAction: 2018-03-14
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41

commit 148c5a06a07d3c8e9dbb8663c6c184088d6b4f41
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Mar 08 14:50:02 2018

Add EG test for infobar with adaptive toolbar

This CL adds an Earl Grey test to check the interactions between the
infobars and the bottom adaptive toolbar.

Bug:  804747 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife30026fd1390d4b86896aca2f7f0f33407926cc
Reviewed-on: https://chromium-review.googlesource.com/955023
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541795}
[modify] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/infobars/infobar_egtest.mm
[add] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/infobars/test_infobar_delegate.h
[add] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/infobars/test_infobar_delegate.mm
[modify] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/148c5a06a07d3c8e9dbb8663c6c184088d6b4f41/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 6 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment