New issue
Advanced search Search tips

Issue 804741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocking:
issue 804740



Sign in to add a comment

Adaptive Toolbar: Displayed above the bottom toolbar when it is displayed.

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
Blocking: 804740
NextAction: 2018-02-28
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d51ed9c889a08c0df19e0ee317ce8972c0f43734

commit d51ed9c889a08c0df19e0ee317ce8972c0f43734
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Feb 21 09:14:18 2018

Position infobars relatively to the bottom toolbar

This CL positions the infobars relatively to the bottom toolbar, taking
into account the fullscreen progress and the presence/absence.

Bug:  804741 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I10f93fc77ade47fd9a90c74476b2e4c96333b676
Reviewed-on: https://chromium-review.googlesource.com/925362
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538044}
[modify] https://crrev.com/d51ed9c889a08c0df19e0ee317ce8972c0f43734/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/d51ed9c889a08c0df19e0ee317ce8972c0f43734/ios/chrome/browser/ui/infobars/infobar_view.mm
[modify] https://crrev.com/d51ed9c889a08c0df19e0ee317ce8972c0f43734/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm
[modify] https://crrev.com/d51ed9c889a08c0df19e0ee317ce8972c0f43734/ios/chrome/browser/ui/util/named_guide.h
[modify] https://crrev.com/d51ed9c889a08c0df19e0ee317ce8972c0f43734/ios/chrome/browser/ui/util/named_guide.mm

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-02-28

Comment 6 by cmasso@google.com, Feb 28 2018

NextAction: ----

Sign in to add a comment