New issue
Advanced search Search tips

Issue 804731 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocking:
issue 804729



Sign in to add a comment

Adaptive Toolbar: Change the location bar constraints such as it is taking full width and reduced height.

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2
Blocking: 804729

Comment 3 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8b17049172e8885bd608a2dc23759502d84eb2

commit 5c8b17049172e8885bd608a2dc23759502d84eb2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 31 10:47:23 2018

Update the LocationBar container during fullscreen

This CL updates the location bar container, updating its background
color and its height to follow the fullscreen progress.
It also updates BVC so the location bar is always displayed.

Bug:  804731 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6f5b2a750cf1593c8d4c7f12163a9db90dc34090
Reviewed-on: https://chromium-review.googlesource.com/883283
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533247}
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/toolbar/public/toolbar_controller_constants.h
[modify] https://crrev.com/5c8b17049172e8885bd608a2dc23759502d84eb2/ios/chrome/browser/ui/toolbar/public/toolbar_controller_constants.mm

Labels: -Q2 Q1
Status: Fixed (was: Assigned)

Sign in to add a comment