New issue
Advanced search Search tips

Issue 804728 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Slide the bottom toolbar out of the screen during fullscreen

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 

Comment 1 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Cc: gambard@chromium.org sczs@chromium.org marq@chromium.org
Issue 811544 has been merged into this issue.
NextAction: 2018-02-28
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276bc84c51e96550f5145aad7df368d575a113a2

commit 276bc84c51e96550f5145aad7df368d575a113a2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Feb 19 09:17:51 2018

Add fullscreen for the bottom toolbar

This CL adds the fullscreen capability for the bottom toolbar.
The other bottom toolbar are still not connected to the bottom toolbar.

Bug:  804728 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I966b5dca9b92e1e31b9746d2eb3ee146e809a419
Reviewed-on: https://chromium-review.googlesource.com/919166
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537608}
[modify] https://crrev.com/276bc84c51e96550f5145aad7df368d575a113a2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/276bc84c51e96550f5145aad7df368d575a113a2/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/276bc84c51e96550f5145aad7df368d575a113a2/ios/public/provider/chrome/browser/voice/voice_search_bar.h

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-02-28
Labels: -Q2 Q1

Comment 9 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment