New issue
Advanced search Search tips

Issue 804726 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Add integration tests

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47eff2848a8f9e961b6aae70809a9405cf554adc

commit 47eff2848a8f9e961b6aae70809a9405cf554adc
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Feb 15 07:50:21 2018

Add EG test for the adaptive toolbar

This CL adds Earl Grey tests for the adaptive toolbar, testing the
different buttons displayed in the toolbars.

Bug:  804726 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If878383cfe8847bddaab251716680bd1d1f9ac6b
Reviewed-on: https://chromium-review.googlesource.com/915347
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536965}
[modify] https://crrev.com/47eff2848a8f9e961b6aae70809a9405cf554adc/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/47eff2848a8f9e961b6aae70809a9405cf554adc/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/47eff2848a8f9e961b6aae70809a9405cf554adc/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[modify] https://crrev.com/47eff2848a8f9e961b6aae70809a9405cf554adc/ios/chrome/browser/ui/toolbar/public/toolbar_controller_constants.h
[modify] https://crrev.com/47eff2848a8f9e961b6aae70809a9405cf554adc/ios/chrome/browser/ui/toolbar/public/toolbar_controller_constants.mm

NextAction: 2018-02-28
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd

commit b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Feb 20 14:43:25 2018

Add EG test to check the toolbar visibility

This CL adds an Earl Grey test to ensure that the toolbar buttons and
the toolbar visibility is correctly updated when the size class changes.

Bug:  804726 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iee3937485ddf379695fabe420ce3311ddea4aba3
Reviewed-on: https://chromium-review.googlesource.com/919061
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537775}
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/b9ad0e7830a5a582b1b7908b2a61ccaa53e21ccd/ios/chrome/browser/ui/uikit_ui_util.mm

Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-02-28

Comment 6 by cmasso@google.com, Feb 28 2018

NextAction: ----

Sign in to add a comment