New issue
Advanced search Search tips

Issue 804717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Create Secondary Toolbar

Project Member Reported by gambard@chromium.org, Jan 23 2018

Issue description

See description

 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d49c3fe02f4fdd409f8e74d4c72084ed550addfa

commit d49c3fe02f4fdd409f8e74d4c72084ed550addfa
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jan 29 08:43:34 2018

Add focus omnibox action to the omnibox button

This CL adds the action to focus the omnibox from the omnibox button in
the bottom toolbar.

Bug:  804717 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id03a2aea1572bb2b23b2aa6733a5cdc1b96ccc33
Reviewed-on: https://chromium-review.googlesource.com/888583
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532355}
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/tab_switcher/tab_switcher.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/toolbar_adapter.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/d49c3fe02f4fdd409f8e74d4c72084ed550addfa/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Labels: -medium large

Sign in to add a comment