[sensors] Define order for "Motion and light sensors" content settings list item |
||||||
Issue descriptionAt the moment, content setting list entry for sensors (under the feature flag) is the last item in the list. The correct order must be specified by the UX team.
,
Jan 23 2018
I'm not sure whether list order is same for desktop, mobile, site specific settings, content settings, page info, etc. Attaching screenshots where information about list item order has to be clarified. Don't mind the icons, I've got correct icons from maxwalker@, just need to rebase CLs / rebuild everything.
,
Jan 23 2018
,
Jan 25 2018
Order for the location bar indicators should be specified as well.
,
Jan 26 2018
,
Feb 5 2018
,
Feb 5 2018
emilyschechter@ suggested putting the new sensor permission after microphone in all cases and that any further decisions on placement would have to come after launch based on usage. I've updated our internal tracking sheet to reflect this. Reassigning to Alexander for implementation.
,
Feb 5 2018
RE #c2: The desktop page info should follow the order in page_info.cc https://cs.chromium.org/chromium/src/chrome/browser/ui/page_info/page_info.cc?rcl=07e9631149979156349349a01760ff53e27a1df5&l=102 but I think you may need to update the order everywhere else.
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3618f65e8df304e0f81cbf6f9a954f28a2202e57 commit 3618f65e8df304e0f81cbf6f9a954f28a2202e57 Author: Alexander Shalamov <alexander.shalamov@intel.com> Date: Tue Feb 13 13:52:43 2018 [sensors] Move sensors setting list item after microphone item Based on UX team feedback in https://crbug.com/804701 the "Motion or light sensors" permission list item should be placed after microphone. Text for the list item should be in normal case, https://crbug.com/796484#c14 Bug: 804701 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I759a1d5090a131cac10680c7df73e0e88298faee Reviewed-on: https://chromium-review.googlesource.com/911571 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#536348} [modify] https://crrev.com/3618f65e8df304e0f81cbf6f9a954f28a2202e57/chrome/app/settings_strings.grdp [modify] https://crrev.com/3618f65e8df304e0f81cbf6f9a954f28a2202e57/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/3618f65e8df304e0f81cbf6f9a954f28a2202e57/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/3618f65e8df304e0f81cbf6f9a954f28a2202e57/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
,
Jun 4 2018
UX team defined the order for new settings item. Issue can be closed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by alexande...@intel.com
, Jan 23 2018