New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804699 link

Starred by 2 users
Status: Fixed
Owner:
jdufault@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
zalcorn@chromium.org
r...@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 778408



Sign in to add a comment

Non-Regression: 'Enable supervised users' option is seen unnecessarily in chrome://settings/accounts page

Project Member Reported by mmanchala@chromium.org, Jan 23 2018 
Chrome Version:  65.0.3325.9/10323.1.0 dev channel Reks,Kip,Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://settings/accounts page
(2)Now observe unnecessary 'Enable supervised users' option (as 'Add supervised user' 3 dot menu in sign-out screen is not available)
(Please refer Video and screenshot)

Expected: 'Enable supervised users' option should not be seen as 'Add supervised user' 3 dot menu in sign-out screen is not available
Actual: Instead  unnecessary 'Enable supervised users' option is seen

This is Non-Regression Issue as 'Add supervised user' 3 dot menu in sign-out screen is removed from  65.0.3322.0

@stevenjb : Please confirm the Issue
Actual_UnnecessaryOption.mp4
16.5 MB Download
Actual_UnnecessaryOption.jpg
515 KB View Download

Comment 1 by steve...@chromium.org, Jan 23 2018

Blocking: 778408
Cc: r...@chromium.org alemate@chromium.org steve...@chromium.org zalcorn@chromium.org
Components: Services>SupervisedUser
Owner: jdufault@chromium.org
-> jdufault@

Comment 2 by jdufault@chromium.org, Jan 24 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62fde099278199e2f2f7e3be01de12a62f4dc93

commit d62fde099278199e2f2f7e3be01de12a62f4dc93
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Jan 31 23:11:40 2018

Remove code for enabling supervised users from settings.

Bug:  804699 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I378d57f3a583b665654e586b720bf73f24dffb12
Reviewed-on: https://chromium-review.googlesource.com/884722
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533466}
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/resources/settings/people_page/profile_info_browser_proxy.js
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/resources/settings/people_page/users_page.js
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/ui/webui/settings/profile_info_handler.h
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/d62fde099278199e2f2f7e3be01de12a62f4dc93/chrome/test/data/webui/settings/test_profile_info_browser_proxy.js

Comment 4 by jdufault@chromium.org, Jan 31 2018

Status: Fixed (was: Started)

Comment 5 by nyerramilli@chromium.org, Feb 2 2018

Labels: Inhouse-HYD-Reported
►

Sign in to add a comment