New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804695 link

Starred by 1 user
Status: Fixed
Owner:
tikuta@chromium.org
Closed: Feb 2018
Cc:
█ rjwright@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

make_core_generated_css_longhand_property_classes step takes more than 30 seconds

Project Member Reported by tikuta@chromium.org, Jan 23 2018 
When I build chrome, I found that make_core_generated_css_longhand_property_classes step takes long time on z840 linux.


~/chromium/src$ touch third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_subclasses.py
~/chromium/src$ time ninja -C out/Release/ make_core_generated_css_longhand_property_classes
ninja: Entering directory `out/Release/'
[2/3] ACTION //third_party/WebKit/Source/core:make_core_generated_css_longhand_property_classes(//build/toolchain/linux:clang_x64)

real    0m32.477s
user    0m32.168s
sys     0m0.296s


Can we improve this time?
Sometimes this 30 seconds step becomes critical path of chrome build when goma backend cache is sufficiently warmed.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d53e00287f64a25663d44f057f314d95bdefa67b

commit d53e00287f64a25663d44f057f314d95bdefa67b
Author: Takuto Ikuta <tikuta@google.com>
Date: Wed Feb 14 06:37:57 2018

Cache template in template_expander

Reading a few template file many times make make_core_generated_css_longhand_property_classes step slow.
This patch improves generating step time of make_core_generated_css_longhand_property_classes from 32.477s to 2.190s by caching template.

Bug:  804695 
Change-Id: I39f7a117b29a502292f00af51485757c73af3166
Reviewed-on: https://chromium-review.googlesource.com/918322
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#536665}
[modify] https://crrev.com/d53e00287f64a25663d44f057f314d95bdefa67b/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_subclasses.py
[modify] https://crrev.com/d53e00287f64a25663d44f057f314d95bdefa67b/third_party/WebKit/Source/build/scripts/template_expander.py

Comment 2 by tikuta@chromium.org, Feb 14 2018

Owner: tikuta@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment