New issue
Advanced search Search tips

Issue 804694 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 624694



Sign in to add a comment

Replace WebScheduler::TimerTaskRunner and RenderSchedulerImpl::TimerTaskQueue with other appropriate task runners

Project Member Reported by hajimehoshi@chromium.org, Jan 23 2018

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f6ae4dc4e1aab937824b5ce4c3dd533f1b35d5

commit d3f6ae4dc4e1aab937824b5ce4c3dd533f1b35d5
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jan 25 12:23:48 2018

Replace the default timer task runner usages in tests

This is part of efforts to replace non-per-frame task runners with other
appropriate per-frame task runners in the renderer.

Bug:  804694 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifcbf610a71e87f5570c3c0b5ffcda97fe10bfc39
Reviewed-on: https://chromium-review.googlesource.com/886441
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531868}
[modify] https://crrev.com/d3f6ae4dc4e1aab937824b5ce4c3dd533f1b35d5/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp
[modify] https://crrev.com/d3f6ae4dc4e1aab937824b5ce4c3dd533f1b35d5/third_party/WebKit/Source/platform/graphics/test/FakeScrollableArea.h
[modify] https://crrev.com/d3f6ae4dc4e1aab937824b5ce4c3dd533f1b35d5/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e0570f96328f62c44fed9297caa8213aef44ed4

commit 2e0570f96328f62c44fed9297caa8213aef44ed4
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Jan 29 06:48:23 2018

document: Remove the default timer task runner usage from Document

Now it is assured that all the tasks in a task runner are executed
before the task runner is deleted, it is no longer needed to set the
default timer task runner when shutting down the document.

This is part of efforts to replace non-per-frame task runners with other
appropriate per-frame task runners in the renderer.

Bug:  804694 
Change-Id: I03150b0412df185f2d61abfd8dcab44bfbdc2a12
Reviewed-on: https://chromium-review.googlesource.com/885691
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532337}
[modify] https://crrev.com/2e0570f96328f62c44fed9297caa8213aef44ed4/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2e0570f96328f62c44fed9297caa8213aef44ed4/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp
[modify] https://crrev.com/2e0570f96328f62c44fed9297caa8213aef44ed4/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5172f79c3a1d1b5395bde328b9da834fc46efda

commit a5172f79c3a1d1b5395bde328b9da834fc46efda
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 01 10:13:33 2018

Replace the default timer task runner usages with per-frame (context) task runners

This is part of efforts to replace non-per-frame task runners with other
appropriate per-frame task runners in the renderer.

Bug:  804694 
Change-Id: I2388bfcde19a2ff9e70ac9b2431035c3310680db
Reviewed-on: https://chromium-review.googlesource.com/883481
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533619}
[modify] https://crrev.com/a5172f79c3a1d1b5395bde328b9da834fc46efda/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/a5172f79c3a1d1b5395bde328b9da834fc46efda/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h

Blockedon: 624694
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/883900203b848aee255dcbb39d08ade423afa8d2

commit 883900203b848aee255dcbb39d08ade423afa8d2
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Feb 02 08:34:37 2018

svg: Replace Timer usages with TaskRunnerTimer in SVGImageTest

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16585f0cf479191f33fdac9a7afc924cd077b908
Reviewed-on: https://chromium-review.googlesource.com/897318
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533992}
[modify] https://crrev.com/883900203b848aee255dcbb39d08ade423afa8d2/third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2415f4601ffba94d66ca9e00bd37ed37a75a2ef7

commit 2415f4601ffba94d66ca9e00bd37ed37a75a2ef7
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Feb 02 12:09:53 2018

scroll: Replace the default timer task runner with one for testing

This is part of efforts to replace non-per-frame task runners with other
appropriate task runners in the renderer.

Bug:  804694 
Change-Id: Ibcb96b6461fda0d777edcb961bc21294fcc5cf23
Reviewed-on: https://chromium-review.googlesource.com/897308
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534026}
[modify] https://crrev.com/2415f4601ffba94d66ca9e00bd37ed37a75a2ef7/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp
[modify] https://crrev.com/2415f4601ffba94d66ca9e00bd37ed37a75a2ef7/third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h
[modify] https://crrev.com/2415f4601ffba94d66ca9e00bd37ed37a75a2ef7/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp
[modify] https://crrev.com/2415f4601ffba94d66ca9e00bd37ed37a75a2ef7/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62168119fd44f7d65aeba38729054975b2774c07

commit 62168119fd44f7d65aeba38729054975b2774c07
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Feb 05 08:07:19 2018

Replace Timer usages with TaskRunnerTimer in V8GCForContextDispose

This CL also introduces WebScheduler::DefaultTaskRunner.

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I0ccbb7b0ab3e5706eb7f1bcf3dff8f913d8a268f
Reviewed-on: https://chromium-review.googlesource.com/897175
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534347}
[modify] https://crrev.com/62168119fd44f7d65aeba38729054975b2774c07/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp
[modify] https://crrev.com/62168119fd44f7d65aeba38729054975b2774c07/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.h

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdaadea6a229bc677230144a7d778aa5f3efab74

commit bdaadea6a229bc677230144a7d778aa5f3efab74
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 06 09:21:47 2018

inspector: Replace Timer usages with TaskRunnerTimer in ThreadDebugger

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: Ia70a8e31394d9d3e6897271a0aa88027824467ef
Reviewed-on: https://chromium-review.googlesource.com/901062
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534666}
[modify] https://crrev.com/bdaadea6a229bc677230144a7d778aa5f3efab74/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/bdaadea6a229bc677230144a7d778aa5f3efab74/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dff30f28d00e248408594bff53fcfdaf6579eb6c

commit dff30f28d00e248408594bff53fcfdaf6579eb6c
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 06 10:03:06 2018

inspector: Replace Timer usages with TaskRunnerTimer in InspectorRevalidateDOMTask

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I0c9b53b15ddca0b65312f599f1cc83ace14f8b75
Reviewed-on: https://chromium-review.googlesource.com/896678
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534671}
[modify] https://crrev.com/dff30f28d00e248408594bff53fcfdaf6579eb6c/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed531bd5ae325f1964ab2db962c4bf75625c95f

commit 6ed531bd5ae325f1964ab2db962c4bf75625c95f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 08 05:01:47 2018

dom: Remove PresentationAttributeCacheCleaner

PresentationAttributeCacheCleaner was introduced before purging memory
was introduced.

This CL removes PresentationAttributeCacheCleaner to clear cache soon
instead of delyaing with timers.

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I7ed775d4b998be82e35d8eefe1f7bd4e0d0145a2
Reviewed-on: https://chromium-review.googlesource.com/903942
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535306}
[modify] https://crrev.com/6ed531bd5ae325f1964ab2db962c4bf75625c95f/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e466cc1176ea479a372feebf7ad76d94586bcb7

commit 8e466cc1176ea479a372feebf7ad76d94586bcb7
Author: Abhishek Arya <inferno@chromium.org>
Date: Sat Feb 10 01:55:23 2018

Revert "dom: Remove PresentationAttributeCacheCleaner"

This reverts commit 6ed531bd5ae325f1964ab2db962c4bf75625c95f.

Reason for revert: Caused multiple security regressions, see  bug 810368 .

Original change's description:
> dom: Remove PresentationAttributeCacheCleaner
> 
> PresentationAttributeCacheCleaner was introduced before purging memory
> was introduced.
> 
> This CL removes PresentationAttributeCacheCleaner to clear cache soon
> instead of delyaing with timers.
> 
> This is part of efforts to replace default timer task runners with
> other appropriate task runners in the renderer.
> 
> Bug:  624694 ,  804694 
> Change-Id: I7ed775d4b998be82e35d8eefe1f7bd4e0d0145a2
> Reviewed-on: https://chromium-review.googlesource.com/903942
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535306}

TBR=jbroman@chromium.org,hayato@chromium.org,hajimehoshi@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  624694 ,  804694 
Change-Id: I921fea361197deefd45968c07917cb5bc6fae0a4
Reviewed-on: https://chromium-review.googlesource.com/912091
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535926}
[modify] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9c4e0fda8e1bd1798230e5f0050052c4b185344

commit a9c4e0fda8e1bd1798230e5f0050052c4b185344
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Feb 14 03:29:04 2018

dom: Reland: Remove PresentationAttributeCacheCleaner

This CL is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/903942,
but adds fix for use-after-poison.

PresentationAttributeCacheCleaner was introduced before purging memory
was introduced.

This CL removes PresentationAttributeCacheCleaner to clear cache soon
instead of delyaing with timers.

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: Ief4ab5240f1c93bf2383a7ed3de61391bd616f8c
Reviewed-on: https://chromium-review.googlesource.com/916162
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536636}
[modify] https://crrev.com/a9c4e0fda8e1bd1798230e5f0050052c4b185344/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d783fd236b00c429385e6e1960b491b689e8ff

commit b8d783fd236b00c429385e6e1960b491b689e8ff
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Feb 14 17:26:41 2018

resource: Remove Timer usages from SVGImageChromeClient

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id745eed43a86ce079fd870586ce6169b928ba1dd
Reviewed-on: https://chromium-review.googlesource.com/917884
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536744}
[modify] https://crrev.com/b8d783fd236b00c429385e6e1960b491b689e8ff/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03c55b230fda790e170ae999c1b95b92aa3ea752

commit 03c55b230fda790e170ae999c1b95b92aa3ea752
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Feb 16 13:15:57 2018

Remove Timer usages from OomInterventionImpl

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Note that this CL adds a usage of default timer task queue via WebThread
::GetTaskRunner(), but I think this is inevitable.

Bug:  624694 ,  804694 
Change-Id: I3a18dc9908850096050de16c66f3c78aa0e3c666
Reviewed-on: https://chromium-review.googlesource.com/923833
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537293}
[modify] https://crrev.com/03c55b230fda790e170ae999c1b95b92aa3ea752/third_party/WebKit/Source/controller/OomInterventionImpl.cpp
[modify] https://crrev.com/03c55b230fda790e170ae999c1b95b92aa3ea752/third_party/WebKit/Source/controller/OomInterventionImpl.h

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22

commit 085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Feb 19 06:27:43 2018

resource: Remove Timer usages from ImageResource

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: Ic6983b6f0a2b5039db1473662d2e7627dd67b5e1
Reviewed-on: https://chromium-review.googlesource.com/903903
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537587}
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/core/loader/resource/ImageResource.h
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/085dec01a176f8f6fb3b1e9b1ff8a34cb8152b22/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/237ff18a05d60ee3a38c17b056d46c46f48079c6

commit 237ff18a05d60ee3a38c17b056d46c46f48079c6
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Feb 19 09:39:27 2018

Remove Timer usages from TimerPerfTest

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I72ba24174da8d1557d4963b0f4336b50b2f01667
Reviewed-on: https://chromium-review.googlesource.com/925124
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537613}
[modify] https://crrev.com/237ff18a05d60ee3a38c17b056d46c46f48079c6/third_party/WebKit/Source/platform/TimerPerfTest.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd08c73d1fbda302b813249cc68ba87575892ed

commit 0dd08c73d1fbda302b813249cc68ba87575892ed
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 05:37:29 2018

Remove Timer usages from TimerTest

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I4115f9c706c735c73bdb14f7243c0e8142293028
Reviewed-on: https://chromium-review.googlesource.com/924101
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537722}
[modify] https://crrev.com/0dd08c73d1fbda302b813249cc68ba87575892ed/third_party/WebKit/Source/platform/TimerTest.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83da8673ea2e3ba3d27a7383b1b7cf27da565990

commit 83da8673ea2e3ba3d27a7383b1b7cf27da565990
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 06:10:49 2018

Remove Timer usages from ScrollableArea

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: Ibe59f2d49e197f7badc2832482de7849c4e2da09
Reviewed-on: https://chromium-review.googlesource.com/923875
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537725}
[modify] https://crrev.com/83da8673ea2e3ba3d27a7383b1b7cf27da565990/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18fbf5cdf41ac1870f34ec6e446ef4cb39143695

commit 18fbf5cdf41ac1870f34ec6e446ef4cb39143695
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 10:31:07 2018

Remove Timer usages from ScrollableAreaMac

This is the counterpart for Mac of https://chromium-review.googlesource.com/c/chromium/src/+/923875

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: I9d3696671e71c44dff39da0c50c0a4b8e112e737
Reviewed-on: https://chromium-review.googlesource.com/925880
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537752}
[modify] https://crrev.com/18fbf5cdf41ac1870f34ec6e446ef4cb39143695/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd192b2fbe0ee0f00d3a0b796b482deccd280621

commit dd192b2fbe0ee0f00d3a0b796b482deccd280621
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 11:22:37 2018

Remove Timer

Now Timer is no longer used. Remove this.

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  624694 ,  804694 
Change-Id: Ic0a0eccdfb9f98c0be8024d4f39a9c2b2ade5c9f
Reviewed-on: https://chromium-review.googlesource.com/926083
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537756}
[modify] https://crrev.com/dd192b2fbe0ee0f00d3a0b796b482deccd280621/third_party/WebKit/Source/platform/Timer.h

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1023ea047908163438fc9d986a09fa2066347019

commit 1023ea047908163438fc9d986a09fa2066347019
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 22 06:32:58 2018

Remove WebScheduler::TimerTaskRunner

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  804694 
Change-Id: I97aea6646f32e08116825d45c2b47b1866f79c47
Reviewed-on: https://chromium-review.googlesource.com/928186
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538366}
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/Timer.cpp
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/Timer.h
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/1023ea047908163438fc9d986a09fa2066347019/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cecc0c6b0ea54f5ae799cc5e2e078ed336022927

commit cecc0c6b0ea54f5ae799cc5e2e078ed336022927
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 22 10:45:24 2018

scheduler: Remove the default timer task runner

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug:  804694 
Change-Id: Ibffdf2c01989ad52cac18fd308a9d3dd7c507b66
Reviewed-on: https://chromium-review.googlesource.com/930523
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538395}
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/cecc0c6b0ea54f5ae799cc5e2e078ed336022927/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Status: Fixed (was: Started)
Done!

Sign in to add a comment