Issue 804691 link

Starred by 1 user

Issue metadata

Status:	Available
Owner:	----
Cc:	fukino@chromium.org yamaguchi@chromium.org tetsui@chromium.org
Components:	Platform>Apps>FileManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
CrOSFilesFeature-CloudImport Files-Fixit-2018

Metadata cache not refreshed

Project Member Reported by yamaguchi@chromium.org, Jan 23 2018

Issue description

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/background/js/metadata_proxy.js?q=metadataProxy.getEntryMetadata&sq=package:chromium&l=26

metadata_proxy gives the old data even after a file is updated or replaced with different content until the background page is closed.
It affects the quota estimation with Cloud Import ( Issue 677104 ).

Comment 1 by yamaguchi@chromium.org, Jan 23 2018

Owner: tetsui@chromium.org
Status: Assigned (was: Available)

tetsui@:
Will you describe how much the caching logic affects the UI performance?

I am now looking for a way to hook individual file updates in a directory, but we may need to refresh the entire cache for directory subtree if it were infeasible.

Comment 2 by tetsui@chromium.org, Jan 23 2018

Cc: tetsui@chromium.org fukino@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)

You can easily experiment how much the performance is affected by following the steps in #0 of  Issue 712121 . (Although IIRC the performance was slightly regressed after my fix, as new metadata fetch is introduced after that.) For the numbers, the cache shortens the copying time from ~30seconds per file to a few seconds.

Also, the problem of when to update metadata cache seems nontrivial on some non-standard devices such as MTP ones.

On the other hand, it should be easy to fetch metadata without cache for some cases where accuracy of metadata is crucial e.g. Cloud Import quota estimation.

It's almost half year since I stopped working on FilesApp actively, so I'm not so familiar with the recent situation.