New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804686 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Mar 2018
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression: Navigating to WiFi subpage while clicking near the toggle button of WiFi section

Project Member Reported by rkalavakuntla@chromium.org, Jan 23 2018 
Chrome Version:65.0.3325.9/10323.1.0 dev channel Reks,Kip,Daisy
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Goto Chrome://settings->Network section(Make sure WiFi enabled)
(2)Now click beside (i.e, L.H.S of) toggle button and observe(kindly refer video)

Expected: Toggle button of WiFi should get disabled
Actual:Instead, it navigates to its subpage.

This is a Non-Regression as same is seen in M-62

Note:Issue is not seen in Linux,Windows OS 

Attaching screencast for reference..

@stevenjb: Please confirm the issue.
Actualtogglefail.webm
293 KB View Download

Comment 1 by steve...@chromium.org, Jan 23 2018

Cc: dschuyler@chromium.org
Labels: -Pri-2 -M-65 M-66 Pri-3
Status: Available (was: Assigned)
Fairly minor issue, but agreed we should make the entire toggle section a toggle hit target. We have the same issue with the bluetooth toggle. (Those are the only toggle + subpage boxes in settings that I am aware of).

Comment 2 by steve...@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 3 by nyerramilli@chromium.org, Feb 2 2018

Labels: Inhouse-HYD-Reported

Comment 4 by steve...@chromium.org, Mar 6 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a29f224c8f927ba7a6adf4461ca36db2d81865a8

commit a29f224c8f927ba7a6adf4461ca36db2d81865a8
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Mar 07 17:40:03 2018

Network settings: Fix click targets for list items

Bug:  804686 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I12f8b20ee210f436e1d4858eddb66a6fa112faaf
Reviewed-on: https://chromium-review.googlesource.com/952033
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541487}
[modify] https://crrev.com/a29f224c8f927ba7a6adf4461ca36db2d81865a8/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/a29f224c8f927ba7a6adf4461ca36db2d81865a8/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
[modify] https://crrev.com/a29f224c8f927ba7a6adf4461ca36db2d81865a8/chrome/browser/resources/settings/internet_page/network_summary_item.html

Comment 6 by steve...@chromium.org, Mar 7 2018

Labels: -M-66 M-67
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37f3f019cd4a405f4ec7b9645d1470162456cdd6

commit 37f3f019cd4a405f4ec7b9645d1470162456cdd6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Mar 08 17:06:33 2018

Known networks: fix network list alignment

Bug:  804686 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6d56e8640ad946ca9e2b25629fac4f04fae7a1f
Reviewed-on: https://chromium-review.googlesource.com/954349
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541814}
[modify] https://crrev.com/37f3f019cd4a405f4ec7b9645d1470162456cdd6/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
►

Sign in to add a comment