New issue
Advanced search Search tips

Issue 804682 link

Starred by 1 user
Status: Fixed
Owner:
bashi@chromium.org
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 715640



Sign in to add a comment

Flaky test external/wpt/service-workers/service-worker/navigation-preload/resource-timing.https.html

Project Member Reported by falken@chromium.org, Jan 23 2018 
This test is flaky on Mac.

It fails with:
FAIL Navigation Preload Resource Timing. assert_equals: performance.getEntriesByName() must returns one PerformanceResourceTiming entry for the navigation preload. expected 1 but got 0

This is not the same failure as fixed  issue 799127 , which failed with:
FAIL Navigation Preload Resource Timing. assert_greater_than_equal: domainLookupEnd >= domainLookupStart of https://web-platform.test:8444/service-workers/service-worker/navigation-preload/resources/resource-timing-scope.py?type=normal expected a number greater than or equal to 14.20000000143773 but got 14.19999999779975

So it's a different bug.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82e59a071fab3d257d2ffba88e565354a5d980cd

commit 82e59a071fab3d257d2ffba88e565354a5d980cd
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jan 23 07:44:45 2018

NetworkService: Gardening: Some service worker tests are passing.

- resource-timing.https.html is flaky but due to a different issue
- The other tests are passing in NetworkService locally. I'm not sure
if they pass all the time because Flakiness Dashboard isn't working
for NetworkService LayoutTests, so if they fail again just readd
them.

TBR=kinuko@chromium.org

Bug:  804682 , 799127 , 715640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I28af3819788364fc08194dfa87cd550fcc5f967e
Reviewed-on: https://chromium-review.googlesource.com/880249
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531175}
[modify] https://crrev.com/82e59a071fab3d257d2ffba88e565354a5d980cd/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/82e59a071fab3d257d2ffba88e565354a5d980cd/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by falken@chromium.org, Jun 8 2018

Blocking: 715640
Labels: Proj-Servicification-Canary Target-69
This test is mostly passing on default, but occasionally flakes still.

It is much more flaky when S13nSW is on. Not sure whether it has to do with S13nSW or NetworkService, since there's no flakiness dashboard results for NetworkService.

Setting it to block S13nSW.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=navigation-preload%2Fresource-timing.https.html

Comment 3 by falken@chromium.org, Jun 8 2018

Owner: bashi@chromium.org
Status: Assigned (was: Available)
bashi: Can I add this to your queue?

Note that I'm not sure whether the flakes are due to NetworkService or ServiceWorkerServicifcation.

Comment 4 Deleted

Comment 5 by falken@chromium.org, Jun 8 2018 

See related  issue 846631 .

Comment 6 by dxie@google.com, Jun 19 2018

Labels: -Proj-Servicification-Canary Hotlist-KnownIssue

Comment 7 by falken@chromium.org, Aug 16 

bashi@ I believe you may have fixed this as part of another bug about rockot's Mojo patch.

Comment 8 by bashi@chromium.org, Aug 16

Status: Fixed (was: Assigned)
Thanks for the heads-up. Yes, I think https://chromium-review.googlesource.com/c/chromium/src/+/1170679 will fix this.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/301fbdd29de4736ff76f95f8639d1e67e720b247

commit 301fbdd29de4736ff76f95f8639d1e67e720b247
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Nov 28 08:12:46 2018

Gardening: Remove failing expectation for navigation-preload/resource-timing.https.html

This bug has already been fixed by r583483.

Bug:  804682 
Change-Id: Ica4adb5b8f390a14c721f644afa69a2d394e3a69
TBR: bashi
Reviewed-on: https://chromium-review.googlesource.com/c/1353054
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611595}
[modify] https://crrev.com/301fbdd29de4736ff76f95f8639d1e67e720b247/third_party/blink/web_tests/TestExpectations
►

Sign in to add a comment