New issue
Advanced search Search tips

Issue 804674 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

mac_views_browser build regression (r530907)

Project Member Reported by tapted@chromium.org, Jan 23 2018 
regressed in https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.10%20MacViews/builds/30865

suspecting r530907

Current error is.

[19638/21653] SOLINK 'obj/chrome/chrome_framework_shared_library/Chromium Framework' 'obj/chrome/chrome_framework_shared_library/Chromium Framework.TOC'
FAILED: obj/chrome/chrome_framework_shared_library/Chromium Framework obj/chrome/chrome_framework_shared_library/Chromium Framework.TOC 
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_BrowserWindowController", referenced from:
      objc-class-ref in libui.a(browser_window_command_handler.o)
      objc-class-ref in libui.a(chrome_command_dispatcher_delegate.o)
  "_OBJC_CLASS_$_TabWindowController", referenced from:
      objc-class-ref in libui.a(share_menu_controller.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-shared', '-Wl,-
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ccdeb33ee5dfcc68e4184666b9ace3abba7427

commit 90ccdeb33ee5dfcc68e4184666b9ace3abba7427
Author: Trent Apted <tapted@chromium.org>
Date: Tue Jan 23 23:54:22 2018

MacViewsBrowser: Introduce browser_window_views_mac.h - helper functions

We are going to have some code that needs to work either with
(mac_views_browser) views browser windows or Cocoa browser windows.
Before r530907 mac_views_browser builds managed to always get a nil
BrowserWindowController. That worked with objc_msgSend even though
it was never linked in. But r530907 adds a static method call, which
wants the BrowserWindowController @implementation.

We need a way to disallow browser_window_controller.h from being
included at all, before it can be phased out.

This CL sets up a file to help consumers that need to work with both
browser window types to remove their browser_window_controller.h
dependencies. For now, it's used enough just to fix the
mac_views_browser compile regression.

Bug:  804674 
Change-Id: I0ce2b94a8d74c8f3f8b7dacec580366819c5aa29
Reviewed-on: https://chromium-review.googlesource.com/880426
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531387}
[modify] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/browser_window_cocoa_views_mac.mm
[modify] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[add] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/browser_window_views_mac.h
[add] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/browser_window_views_mac.mm
[modify] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm
[modify] https://crrev.com/90ccdeb33ee5dfcc68e4184666b9ace3abba7427/chrome/browser/ui/cocoa/share_menu_controller.mm
►

Sign in to add a comment