New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Change base::Bind and base::Closure to base::BindOnce and base::OnceClosure

Project Member Reported by ortuno@chromium.org, Jan 23 2018

Issue description

Our use of base::Bind and base::Closure is causing presubmit warnings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b499eff54033b2f91d828bdf2ed66b7f652eb6

commit 59b499eff54033b2f91d828bdf2ed66b7f652eb6
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Jan 29 01:22:44 2018

desktop-pwas: Change base::Bind and base::Closure to base::BindOnce and base::OnceClosure

Changes all uses of base::Bind and base::Closure in
BookmarkAppNavigationThrottle code. base::Bind and base::Closure are
deprecated in favor of base::BindOnce and base::OnceClosure.

Bug:  804653 
Change-Id: Idc4b84649b52835d67aaedd83c50cb7c0e0a7c00
Reviewed-on: https://chromium-review.googlesource.com/880082
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532301}
[modify] https://crrev.com/59b499eff54033b2f91d828bdf2ed66b7f652eb6/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/59b499eff54033b2f91d828bdf2ed66b7f652eb6/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc

Comment 2 by ortuno@chromium.org, Jan 29 2018

Status: Fixed (was: Started)

Sign in to add a comment