Issue metadata
Sign in to add a comment
|
The user can use an infobar to restore tabs after a crash |
||||||||||||||||||||||
Issue descriptionUser can see the infobar when launching after a crash. User can use the “Restore” button to restore tabs, or close the infobar to take no action. - Update (or more likely, fork) InfoBarView to adopt new styling for text and buttons. - Verify that the OK and Close buttons are hooked up properly.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Feb 28 2018
,
Apr 5 2018
,
Apr 16 2018
,
Apr 28 2018
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de24a31a811aa4a60ce31598285801283c87bcd0 commit de24a31a811aa4a60ce31598285801283c87bcd0 Author: Peter K. Lee <pkl@chromium.org> Date: Mon Apr 30 14:10:24 2018 Consolidated constants into a single data structure To enable relayout of Infobar based on experiment flags, consolidation helps with wholesale changes of these layout constants. Bug: 804652 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0764fb5b8c0b85723f6a3e24169d345f6ea24497 Reviewed-on: https://chromium-review.googlesource.com/1033502 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#554741} [modify] https://crrev.com/de24a31a811aa4a60ce31598285801283c87bcd0/ios/chrome/browser/ui/infobars/infobar_view.mm
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e17675341b6296ee83b34c2b4ebe094c7d07907 commit 1e17675341b6296ee83b34c2b4ebe094c7d07907 Author: Peter K. Lee <pkl@chromium.org> Date: Fri May 04 20:48:09 2018 Add Infobar Phase 1 UI changes. This CL adds small tweaks to the UI and layout to bring infobar closer to Phase 1 design. Bug: 804652 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8da40c032387eb9f7f06ad60e6c3283dea56bf8 Reviewed-on: https://chromium-review.googlesource.com/1036541 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556183} [add] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/app/theme/default_100_percent/infobar_close.png [add] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/app/theme/default_200_percent/infobar_close.png [add] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/app/theme/default_300_percent/infobar_close.png [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/app/theme/ios_theme_resources.grd [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/infobars/infobar_view.mm [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/ui_feature_flags.h [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/ui_util.h [modify] https://crrev.com/1e17675341b6296ee83b34c2b4ebe094c7d07907/ios/chrome/browser/ui/ui_util.mm
,
May 9 2018
Pete/Martijn: Starting with 68.0.3425.0 canary, you can flip the #infobars-ui-reboot flag in chrome://flags to enabled to see the new Infobar layout. I have several questions that needs your input: More specific info about the layout of the infobar. 1. Rounded corner radius for the image background is 12px as shown. Is that correct? 2. Rounded corner radius for the "Restore" button is 11px as shown. Is that correct? 3. Please review the font used. The body text is [UIFont preferredFontForTextStyle:UIFontTextStyleSubheadline] and the button label is [UIFont preferredFontForTextStyle:UIFontTextStyleHeadline]. 4. Do we need a new icon or is the "sad folder" used in Bling going to be used in Bijou as well. 5. The small dismiss "x" for Bijou at the top right is about 2/3 the size of that used in Bling. I need the image assets in PNG for all 3 resolutions. FYI, the Bling image is 24x24 in dimension with transparent background and the "x" is about 14x14. 6. Does the infobar in Bijou have a light gray background? 7. The text in the Bijou infobar will support Dynamic Type. Please confirm.
,
May 9 2018
The NextAction date has arrived: 2018-05-09
,
May 9 2018
I think this should be considered "Fixed". See comment 11. The remaining questions in comment 12 can be tracked as new bugs.
,
May 15 2018
Verified in 68.0.3431.0 Canary, iPhone X iOS 11.4 beta 3, iPhone 6 iOS 10.3.3, Restore info-bar works well, Restore button works fine, X dismisses the info-bar. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkl@chromium.org
, Jan 23 2018