Update: I just got a WhatsApp notification from a different profile, and a dynamite notification from the same profile, which both auto dismissed, so this appears to be limited to calendar notifications.

Yeah, calendar marks their notifications and staying on-screen. Which Linux distribution do you use, Ben?

Tom, I guess there isn't a way to detect whether a server supports close buttons? It's probably a good idea to add our own for this distro.

> Tom, I guess there isn't a way to detect whether a server supports close buttons? 

Nope :(

> It's probably a good idea to add our own for this distro.

We could do that.  I noticed this issue for calendar notifications on Cinnamon, and it was bugging me.

benwells@ are you using the cinnamon DE? (you can check with the XDG_CURRENT_DESKTOP environment var)

XDG_CURRENT_DESKTOP is X-Cinnamon.

For now I'm  turning off the native notifications flag as it is really bugging me, and calendar notifications are policy enabled for us lucky googlers.

If we can detect that we're using Cinnamon, how about we always add a [Close] button? While less severe, we'll have the same issue with notifications that use a regular timeout. (Either activate or wait until it disappears.)

> If we can detect that we're using Cinnamon, how about we always add a [Close] button?
sgtm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5688e36bf038d9d42c01079eaa48c118c3b832fd

commit 5688e36bf038d9d42c01079eaa48c118c3b832fd
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jan 25 03:05:59 2018

Linux native notifications: Add close button on cinnamon notifications

BUG= 804637 
R=peter

Change-Id: I06611b6d8569c05dc4349121d565b645a3359c6b
Reviewed-on: https://chromium-review.googlesource.com/884572
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531800}
[modify] https://crrev.com/5688e36bf038d9d42c01079eaa48c118c3b832fd/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/5688e36bf038d9d42c01079eaa48c118c3b832fd/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

peter: should we merge this to M64?

It's very late for M64. Let's stick with M65 for now.

If all goes really bad we can consider looking in to using the kill switch.

TPMs: This is a small and tested CL that only affects Linux users using Cinnamon who use notifications.

Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6336010938050bcb5b0033fc5455e476c42ee41f

commit 6336010938050bcb5b0033fc5455e476c42ee41f
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jan 26 18:36:51 2018

[Merge to M65] Linux native notifications: Add close button on cinnamon notifications

> BUG= 804637 
> R=peter
>
> Change-Id: I06611b6d8569c05dc4349121d565b645a3359c6b
> Reviewed-on: https://chromium-review.googlesource.com/884572
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531800}

BUG= 804637 
TBR=peter
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If611561a66d0d1c81c99560e31f5568b22ae1aef
Reviewed-on: https://chromium-review.googlesource.com/889407
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#118}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/6336010938050bcb5b0033fc5455e476c42ee41f/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/6336010938050bcb5b0033fc5455e476c42ee41f/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

 Issue 807217  has been merged into this issue.

Requesting post-stable merge to M64.  We're receiving a bunch of complaints from Googlers on mailing lists like chrome-discuss and gLinux-discuss.

This does not require a respin, but if there's going to be a new M64 release, I think it would be a good idea to have the CL from c#7 merged.  The change (minus the unittest) is relatively small and should be a safe merge.

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Thanks for the fix. How safe is this merge? Are we sure this won't break or regress anything else? It seems like a fairly critical bug. This will require a postmortem. 

> How safe is this merge?

It should be safe.  There are some manual notification tests in the testplan, so I would hope that any regressions would be caught by those tests before release.

> Are we sure this won't break or regress anything else?

It's a pretty well-contained change.  I think it would be unlikely.

> It seems like a fairly critical bug. This will require a postmortem. 

drats :(

Approving merge for M64. Branch:3282.

Unrestricting view since I don't see anything internal here, and so we can link people to this as we're getting people repeatedly asking about this bug. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff24b497fe17871b6e829398304b2ad290c488b3

commit ff24b497fe17871b6e829398304b2ad290c488b3
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 31 03:52:13 2018

[Merge to M64] Linux native notifications: Add close button on cinnamon notifications

> BUG= 804637 
> R=peter
>
> Change-Id: I06611b6d8569c05dc4349121d565b645a3359c6b
> Reviewed-on: https://chromium-review.googlesource.com/884572
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531800}

BUG= 804637 
TBR=peter
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I723ddd0747bcecc682dce8d911ceaa5ceb82679c
Reviewed-on: https://chromium-review.googlesource.com/894301
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#627}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/ff24b497fe17871b6e829398304b2ad290c488b3/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/ff24b497fe17871b6e829398304b2ad290c488b3/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

Verified the fix on Linux X-Cinnamon using 64.0.3282.140 , Now we are seeing Close button beside Settings button. Attaching screenshot for reference.

Hence, the fix is working as expected. Adding verified labels.

Thanks...!!

Deleted: 804637.png 124 KB

	804637.png 124 KB View Download

Verified the fix on Linux X-Cinnamon using 65.0.3325.31 , Now we are seeing Close button beside Settings button. Attaching screenshot for reference.

Hence, the fix is working as expected. Adding verified labels.

Thanks...!!

Deleted: In M65.png 111 KB

	In M65.png 111 KB View Download