New issue
Advanced search Search tips

Issue 804635 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Autofill] Bestbuy Signin dont trigger autofill save/no thanks options

Project Member Reported by michaelbai@chromium.org, Jan 23 2018

Issue description

Signing with correct user credential,  autofill save/no thanks option isn't triggered.

see http://b/67373531
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203b8d18dc7da60029a8dee1e47c5e58a2caa797

commit 203b8d18dc7da60029a8dee1e47c5e58a2caa797
Author: Tao Bai <michaelbai@chromium.org>
Date: Wed Jan 24 21:39:07 2018

[WebView Autofill] Keep autofill session alive.

Not reset handler until new autofill session is needed, this will
keep the autofill session alive among the navigation and handle
PROBABLY_FORM_SUBMITTED corretly.

Also popup the SubmissionSource to Java side.

Bug:  804635 
Change-Id: I246ca3e6a8d9dc48f60f3bc90f6d20dcd0bd7a2d
Reviewed-on: https://chromium-review.googlesource.com/879271
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531688}
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/components/autofill/android/BUILD.gn
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/components/autofill/android/autofill_provider_android.h
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/components/autofill/android/java/src/org/chromium/components/autofill/AutofillProvider.java
[modify] https://crrev.com/203b8d18dc7da60029a8dee1e47c5e58a2caa797/components/autofill/core/common/submission_source.h

Labels: -Pri-3 M-65 Merge-Request-65 Pri-1
Cc: dneelame...@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d

commit c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d
Author: Tao Bai <michaelbai@chromium.org>
Date: Mon Jan 29 18:38:42 2018

[WebView Autofill] Keep autofill session alive.

Not reset handler until new autofill session is needed, this will
keep the autofill session alive among the navigation and handle
PROBABLY_FORM_SUBMITTED corretly.

Also popup the SubmissionSource to Java side.

Bug:  804635 
Change-Id: I246ca3e6a8d9dc48f60f3bc90f6d20dcd0bd7a2d
Reviewed-on: https://chromium-review.googlesource.com/879271
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531688}(cherry picked from commit 203b8d18dc7da60029a8dee1e47c5e58a2caa797)
Reviewed-on: https://chromium-review.googlesource.com/891639
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#144}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/components/autofill/android/BUILD.gn
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/components/autofill/android/autofill_provider_android.h
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/components/autofill/android/java/src/org/chromium/components/autofill/AutofillProvider.java
[modify] https://crrev.com/c991cbbb3c9fa215b4d4d2814ede89c26dcfc61d/components/autofill/core/common/submission_source.h

Status: Fixed (was: Assigned)
Trying to verifty this issue on M/66.0.3334.0 don't seems to be fixed yet (don't show the save/no thanks option for autofill feature)

You need to login successfully to get SAVE option.

Comment 9 by battun@chromium.org, Jan 30 2018

Fix issue verified on latest M65:65.0.3325.33

Tested device:Nexus 6P / OPM1.171019.021

Thanks!
Status: Verified (was: Fixed)

Sign in to add a comment