New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Add parser to decode response from CTAP authenticators

Project Member Reported by hongjunchoi@chromium.org, Jan 23 2018

Issue description

Responses from CTAP authenticators are encoded in canonical CBOR format. Add parser to de-serialize byte array response from authenticators into CTAPResponse objects.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29d078b837b295a8e67130f8048136b8a9eaf314

commit 29d078b837b295a8e67130f8048136b8a9eaf314
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Fri Feb 02 01:23:40 2018

Add parser to deserialize authenticator responses

Add support for parsing response received from authenticator to
corresponding CTAPResponse objects.

Bug:  804626 
Change-Id: I3030125371c4ac66c443a6bae938f63757066db7
Reviewed-on: https://chromium-review.googlesource.com/850815
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533895}
[modify] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/BUILD.gn
[modify] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/BUILD.gn
[modify] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/ctap_request_unittest.cc
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/ctap_response_fuzzer.cc
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/ctap_response_fuzzer_corpus/get_assertion_response_corpus
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/ctap_response_fuzzer_corpus/make_credential_response_corpus
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/ctap_response_unittest.cc
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/device_response_converter.cc
[add] https://crrev.com/29d078b837b295a8e67130f8048136b8a9eaf314/device/ctap/device_response_converter.h

Status: Fixed (was: Assigned)

Sign in to add a comment