Write suite:smoke test to enforce consistency across VMs |
||
Issue descriptionWe want to make sure all VMs look the same from the inside. This test will be added to suite:smoke only. I don't think the test needs to check if it actually is in a VM. Call it maybe vm_Sanity? For now we want to enforce: - Installed image is actually meant to be used in the VM. - Compatibility with cros_vm_lib.sh" -- 8GB of RAM -- 8 CPUs -- For now Haswell with feature set consistent to https://chromium-review.googlesource.com/#/c/chromiumos/platform/crosutils/+/877622/1/lib/cros_vm_lib.sh Once we have this test we can drop the "force" parameter to "check" in the change above (warnings only). Advantage: This will allow us to continue running suite:smoke even if the architecture changes under us and the failure will be limited to the vm_Sanity test. Disadvantage: Capabilities need to be tracked in two places. But I guess that is no different from unit tests.
,
Jan 23 2018
Sounds good. Also, we can CQ-DEPEND the two changes.
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1cec8d1b83514e8a316480f2e92494b5981966e7 commit 1cec8d1b83514e8a316480f2e92494b5981966e7 Author: Po-Hsien Wang <pwang@chromium.org> Date: Thu Feb 01 10:41:46 2018 cros_vm: align qemu argument with cros tree 1) Make the qemu argument align with the argument set in cros/src/script/lib/cros_vm_lib.py 2) Add command line options so that user can specifies VM's configuration. BUG= chromium:804619 TEST=./cros_vm --start --dry-run and see the command CQ-DEPEND=CL:877622, CL:887434 Change-Id: I2c96d56b52f20f13bc3b52106a272eecf93ec31c Reviewed-on: https://chromium-review.googlesource.com/887545 Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/1cec8d1b83514e8a316480f2e92494b5981966e7/scripts/cros_vm.py
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9784798ca1f8dd28e000206d90f2244e75f48bde commit 9784798ca1f8dd28e000206d90f2244e75f48bde Author: Po-Hsien Wang <pwang@chromium.org> Date: Thu Feb 01 10:41:46 2018 crosvm_Sanity: verifying vm config persistency Add a test that make sure VM configuration is consistent. BUG= chromium:804619 TEST=test_that --board=betty crosvm_Sanity pyformat crosvm_Sanity utils/run_pylint crosvm_Sanity CQ-DEPEND=CL:877622, CL:887545 Change-Id: I407e6190938de5504921de02c55ddf810d3d374b Reviewed-on: https://chromium-review.googlesource.com/887434 Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [add] https://crrev.com/9784798ca1f8dd28e000206d90f2244e75f48bde/client/site_tests/crosvm_Sanity/control [add] https://crrev.com/9784798ca1f8dd28e000206d90f2244e75f48bde/client/site_tests/crosvm_Sanity/crosvm_Sanity.py
,
Feb 1 2018
We need to make sure the new test runs well everywhere. Right now it actually does not run yet at all, as it isn't added to any autotest ebuild. Can you please do so? For now probably best src/third_party/chromiumos-overlay/chromeos-base/autotest-tests/autotest-tests-9999.ebuild
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8adb876388519c328002b0997b562d9ae8ee66d5 commit 8adb876388519c328002b0997b562d9ae8ee66d5 Author: Po-Hsien Wang <pwang@chromium.org> Date: Sat Feb 03 01:08:42 2018 crosvm_Sanity: relax cpu flag checking Relax cpu flag checking from error to warning as the infra still has lots of baremetal builders and most of them have very different CPU flags set than GCE. BUG= chromium:804619 TEST=pre-cq CQ-DEPEND=CL:898305 Change-Id: I6cc916806a2f135c41e021471750b006ed0207be Reviewed-on: https://chromium-review.googlesource.com/899651 Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Commit-Queue: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/8adb876388519c328002b0997b562d9ae8ee66d5/client/site_tests/crosvm_Sanity/crosvm_Sanity.py
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/37c89a6ef6c7536d2882e614e216b256d948b61e commit 37c89a6ef6c7536d2882e614e216b256d948b61e Author: Po-Hsien Wang <pwang@chromium.org> Date: Tue Feb 06 03:09:21 2018 autotest-tests: Add crosvm_Sanity test. This CL adds the client autotest "crosvm_Sanity" into the ebuild. BUG= chromium:804619 TEST=emerge-betty chromeos-base/autotest-tests && test_that -b betty dut_ip crosvm_Sanity CQ-DEPEND=CL:899651 Change-Id: I9e3bfb34894cf759294b3a348e39eb0461c897cb Reviewed-on: https://chromium-review.googlesource.com/898305 Commit-Ready: Po-Hsien Wang <pwang@chromium.org> Tested-by: Po-Hsien Wang <pwang@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/37c89a6ef6c7536d2882e614e216b256d948b61e/chromeos-base/autotest-tests/autotest-tests-9999.ebuild
,
Feb 7 2018
crosvm_Sanity is run on pre-cq: https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/81156 |
||
►
Sign in to add a comment |
||
Comment 1 by pwang@chromium.org
, Jan 23 2018