New issue
Advanced search Search tips

Issue 804606 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 806122
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 777484



Sign in to add a comment

Crash in loop_filter

Project Member Reported by ClusterFuzz, Jan 23 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6325818891698176

Fuzzer: libFuzzer_mediasource_MP4_AVC1_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x1eaf6a9c82b4
Crash State:
  loop_filter
  ff_h264_execute_decode_slices
  decode_nal_units
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=508791:508824

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6325818891698176

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 23 2018

Components: Internals>Media>FFmpeg
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 23 2018

Labels: M-64
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 23 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 23 2018

Labels: Pri-1

Comment 5 by mea...@chromium.org, Jan 23 2018

Owner: sande...@chromium.org
Status: Assigned (was: Untriaged)
sandersd: Can you please take a look? Thanks.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Security_Impact-Beta Security_Impact-Stable
Cc: awhalley@chromium.org
awhalley@: Is this critical for M64 or can we punt it to 65?

Comment 8 by awhalley@google.com, Jan 31 2018

Labels: -M-64 M-65
We can tackle this in 65
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 6 2018

sandersd: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: dalecur...@chromium.org
Cc: sande...@chromium.org
Owner: xhw...@chromium.org
Blocking: 777484
M65 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge  into the release branch ASAP. Thank you.
Mergedinto: 806122
Status: Duplicate (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f39edca89c5cfc5930f06f81f09491f69829d7

commit 16f39edca89c5cfc5930f06f81f09491f69829d7
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Feb 14 01:05:38 2018

Roll src/third_party/ffmpeg/ f5964c36e..58a80d155 (2 commits)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f5964c36e1dc..58a80d15568f

$ git log f5964c36e..58a80d155 --date=short --no-merges --format='%ad %ae %s'
2018-02-13 xhwang ffmpeg: Set valid qscale value in ff_h264_decode_mb_cavlc()
2018-02-09 xhwang ffmpeg: Fix ctts_index calculation

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 806122 , 804097 , 804606 

Change-Id: I1dfb85059290569fcde7a5e90e7802c7e5a0bf64
Reviewed-on: https://chromium-review.googlesource.com/917199
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536581}
[modify] https://crrev.com/16f39edca89c5cfc5930f06f81f09491f69829d7/DEPS

Project Member

Comment 16 by ClusterFuzz, Feb 14 2018

ClusterFuzz has detected this issue as fixed in range 536580:536611.

Detailed report: https://clusterfuzz.com/testcase?key=6325818891698176

Fuzzer: libFuzzer_mediasource_MP4_AVC1_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x1eaf6a9c82b4
Crash State:
  loop_filter
  ff_h264_execute_decode_slices
  decode_nal_units
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=508791:508824
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=536580:536611

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6325818891698176

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Cc: wolenetz@chromium.org
Project Member

Comment 18 by sheriffbot@chromium.org, May 26 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment