Make PackageInfraGoBinariesStage package all files instead of hardcoded executables under /usr/bin |
|||
Issue descriptionFor issue 782515 , I need to make the contents of the chromeos-base/tast-remote-tests-cros Portage package available on prod machines. This package contains a Go executable at /usr/libexec/tast/bundles/cros and (eventually) various data files under /usr/share/tast/data. My understanding is that infra_stages.PackageInfraGoBinariesStage currently creates CIPD packages containing a hardcoded list of executables under /usr/bin. It seems straightforward to make it instead include all files installed by the relevant Portage packages, and I've started on a change to make it do this. Allen, is there a reason that this won't work, or does it sound fine to you?
,
Jan 23 2018
,
Jan 25 2018
This is done now: --- chromite: Make PackageInfraGoBinariesStage install all files. Update cbuildbot's infra_stages.PackageInfraGoBinariesStage to package all files installed by the specified Portage packages instead of using hardcoded lists of executables under /usr/bin. Also add unit tests for the stage. BUG= chromium:782515 TEST=added unit tests; also did a successful chromeos-infra-go-tryjob build Change-Id: I8208c18f5be5029e625b67ffce5141bc4626d5cc Reviewed-on: https://chromium-review.googlesource.com/881267 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> |
|||
►
Sign in to add a comment |
|||
Comment 1 by ayatane@chromium.org
, Jan 23 2018