Show the correct tab grid toolbars when the size class changes |
|||||||||
Issue descriptionShow the correct tab grid toolbars when the size class changes
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 26 2018
,
Jan 27 2018
,
Feb 26 2018
,
Mar 21 2018
This is related to the page scrollView being set to a weird offset (between two pages) whenever the orientation changes. This was bothering me to no end. So I had to fix it. A CL is in-flight.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a98c6ca6fa00f05052c8a494d46c5c9bf391c68a commit a98c6ca6fa00f05052c8a494d46c5c9bf391c68a Author: edchin <edchin@chromium.org> Date: Wed Mar 21 14:29:40 2018 [ios] Fix tab grid rotation This CL updates the correct page scroll offset and toolbar configuration upon rotation. Bug: 804603 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I055ce3f63204393bdc8ced23f8ed3ec212b0eab8 Reviewed-on: https://chromium-review.googlesource.com/972666 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544689} [modify] https://crrev.com/a98c6ca6fa00f05052c8a494d46c5c9bf391c68a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 23 2018
Lookin' so good. =) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018