Issue metadata
Sign in to add a comment
|
Add custom appearance changes while re-ordering is in process. |
|||||||||||||||||||||||
Issue descriptionAdd custom appearance changes while re-ordering is in process.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Jan 25 2018
,
Jan 26 2018
,
Jan 27 2018
,
Mar 29 2018
,
Apr 5 2018
,
Apr 18 2018
,
Apr 24 2018
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
,
Apr 26 2018
I'm OOO for this cycle, so I'm pushing the NextAction to May 23.
,
Apr 26 2018
Also this is now medium.
,
May 23 2018
The NextAction date has arrived: 2018-05-23
,
May 24 2018
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dddaa552a30aaf600fc8216edc65aa1b05645b45 commit dddaa552a30aaf600fc8216edc65aa1b05645b45 Author: Mark Cogan <marq@google.com> Date: Tue May 29 15:35:57 2018 [iOS] Track user touch when reordering tab grid. This CL tweaks the tab grid interactive reordering so that the tabs don't jump to put their centers under the user's touch point when they are being moved. Bug: 804593 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0914819fc607b9b4c28b4929ae389eac50023181 Reviewed-on: https://chromium-review.googlesource.com/1076333 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#562434} [modify] https://crrev.com/dddaa552a30aaf600fc8216edc65aa1b05645b45/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Jun 6 2018
The NextAction date has arrived: 2018-06-06
,
Jun 27 2018
,
Jul 4
The NextAction date has arrived: 2018-07-04
,
Jul 10
,
Jul 10
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/333e5465e39159758b070066b5a2ba5a6933f0ae commit 333e5465e39159758b070066b5a2ba5a6933f0ae Author: Mark Cogan <marq@google.com> Date: Fri Jul 27 08:03:32 2018 [iOS] Change cell appearance when reordering tabs. This CL introduces an appearance change for the tab grid when tabs are being reordered. It adds a second collection view layout to make all of the non-moving cells slightly transparent, and to make the moving cell slightly larger. Bug: 804593 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6ba416844281aa7a106552c24ef1d9c854bff567 Reviewed-on: https://chromium-review.googlesource.com/1151297 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#578562} [modify] https://crrev.com/333e5465e39159758b070066b5a2ba5a6933f0ae/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h [modify] https://crrev.com/333e5465e39159758b070066b5a2ba5a6933f0ae/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm [modify] https://crrev.com/333e5465e39159758b070066b5a2ba5a6933f0ae/ios/chrome/browser/ui/tab_grid/grid/grid_layout.h [modify] https://crrev.com/333e5465e39159758b070066b5a2ba5a6933f0ae/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm [modify] https://crrev.com/333e5465e39159758b070066b5a2ba5a6933f0ae/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Jul 27
,
Jul 30
Verified on canary.
,
Jul 30
Approved!
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df commit f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df Author: Mark Cogan <marq@google.com> Date: Tue Jul 31 08:37:59 2018 [iOS] Change cell appearance when reordering tabs. This CL introduces an appearance change for the tab grid when tabs are being reordered. It adds a second collection view layout to make all of the non-moving cells slightly transparent, and to make the moving cell slightly larger. Bug: 804593 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6ba416844281aa7a106552c24ef1d9c854bff567 Reviewed-on: https://chromium-review.googlesource.com/1151297 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578562}(cherry picked from commit 333e5465e39159758b070066b5a2ba5a6933f0ae) Reviewed-on: https://chromium-review.googlesource.com/1156284 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#263} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h [modify] https://crrev.com/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm [modify] https://crrev.com/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df/ios/chrome/browser/ui/tab_grid/grid/grid_layout.h [modify] https://crrev.com/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm [modify] https://crrev.com/f78c459ebee14b8dea7b4ae6763e2ce3c7f1b9df/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm |
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)