New issue
Advanced search Search tips

Issue 804590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Customize the styling of Recent Tabs login/sync prompt/warnings to match tab grid style.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Customize the styling of Recent Tabs login/sync prompt/warnings to match tab grid style. 
 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Recent-Tabs-In-Grid

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 5 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----

Comment 7 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 8 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 9 by edchin@chromium.org, Mar 26 2018

Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 10 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-05-23
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c301cef5024aa2796eb01f06ed12bf29b1139e3d

commit c301cef5024aa2796eb01f06ed12bf29b1139e3d
Author: edchin <edchin@chromium.org>
Date: Mon May 21 20:00:30 2018

[ios] Refactor small method in recent tabs

This CL refactors a small piece of code in
RecentTabsTableViewController. This method was previously hard to read
and had superfluous variables.

Bug:  804590 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19af585c6177ef45bb7a6a255a8d3371c5b73073
Reviewed-on: https://chromium-review.googlesource.com/1067081
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560341}
[modify] https://crrev.com/c301cef5024aa2796eb01f06ed12bf29b1139e3d/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

Project Member

Comment 15 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea94f1c38a0afb6a4729e8ffaba324be404b611a

commit ea94f1c38a0afb6a4729e8ffaba324be404b611a
Author: edchin <edchin@chromium.org>
Date: Mon May 21 23:49:06 2018

[ios] Add recent_tabs to showcase

Showcase helps to build pure UI layer components. Currently, the
RecentTabsTableViewController has a mix of UI layer and model layer
code. Dependencies on the model layer make it difficult to reuse
UI layer components. This CL begins to refactor
RecentTabsTableViewController to become pure UI layer, by adding it
to Showcase.

Bug:  804590 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibd46691503dff84be1a274a0f88fd2beeee1589a
Reviewed-on: https://chromium-review.googlesource.com/1067078
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560412}
[modify] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/showcase/BUILD.gn
[modify] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/showcase/core/showcase_model.mm
[add] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/showcase/recent_tabs/BUILD.gn
[add] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/showcase/recent_tabs/sc_dark_theme_recent_tabs_coordinator.h
[add] https://crrev.com/ea94f1c38a0afb6a4729e8ffaba324be404b611a/ios/showcase/recent_tabs/sc_dark_theme_recent_tabs_coordinator.mm

Project Member

Comment 16 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b2a56945a58f742ae57a7c8443dc8529b5270a0

commit 8b2a56945a58f742ae57a7c8443dc8529b5270a0
Author: edchin <edchin@chromium.org>
Date: Tue May 22 02:31:39 2018

[ios] Recent tabs: Move favicon dependency from UI layer to model layer

This CL moves model layer code out of RecentTabsTableViewController.
Previously, model objects (i.e., favicon service) needed to be heavily
mocked in order to be able to plug in this view controller into
Showcase. Now the favicon service is only used in the model layer,
and not the UI layer. The RecentTabsImageDataSource protocol provides
a mechanism to retrieve the favicon from the model layer.

Bug:  804590 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib5848f14f72e29ff9925d1a1749724f07320d198
Reviewed-on: https://chromium-review.googlesource.com/1067080
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560463}
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/BUILD.gn
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
[add] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_image_data_source.h
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.h
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.mm
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/8b2a56945a58f742ae57a7c8443dc8529b5270a0/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

The NextAction date has arrived: 2018-05-23
NextAction: 2018-06-20
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-06-20

Sign in to add a comment