New issue
Advanced search Search tips

Issue 804589 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Customize recent tabs styling to match the tab grid style (light-on-dark).

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Customize the styling to match the tab grid style (light-on-dark).
 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Recent-Tabs-In-Grid

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 5 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----

Comment 7 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 8 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 9 by edchin@chromium.org, Mar 26 2018

Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 10 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-06-06
Status: Started (was: Assigned)
NextAction: 2018-06-13
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1abab4c24f6e5627d0e667edc50eeda1af32b8a1

commit 1abab4c24f6e5627d0e667edc50eeda1af32b8a1
Author: edchin <edchin@chromium.org>
Date: Thu Jun 07 00:14:44 2018

[ios] Add dark style to remote tabs

Bug:  804589 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib1ad651adb3d7c1025ab5e50375bc291cef52aed
Reviewed-on: https://chromium-review.googlesource.com/1090004
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565113}
[modify] https://crrev.com/1abab4c24f6e5627d0e667edc50eeda1af32b8a1/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/1abab4c24f6e5627d0e667edc50eeda1af32b8a1/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/1abab4c24f6e5627d0e667edc50eeda1af32b8a1/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h
[modify] https://crrev.com/1abab4c24f6e5627d0e667edc50eeda1af32b8a1/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329

commit a80bd36e735fdb7af4184ce0c32d5ba9fbd47329
Author: edchin <edchin@chromium.org>
Date: Fri Jun 08 00:13:43 2018

[ios] Dark theme remote tabs

Bug:  804589 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic87877e2e9c3e1a8ddf619abea5fb83af250f7ea
Reviewed-on: https://chromium-review.googlesource.com/1089821
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565476}
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_activity_indicator_header_footer_item.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/chrome_table_view_styler.h
[modify] https://crrev.com/a80bd36e735fdb7af4184ce0c32d5ba9fbd47329/ios/chrome/browser/ui/table_view/chrome_table_view_styler.mm

NextAction: 2018-06-20
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-06-20

Sign in to add a comment