Add cell animation when a new tab opens |
||||||||||||||
Issue descriptionAdd cell animation when a new tab opens
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Jan 26 2018
,
Jan 27 2018
,
Mar 29 2018
,
Apr 5 2018
,
Apr 9 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
,
Apr 17 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d7e87248179c7c06f5d06a9ccf46c9964d9fd98 commit 6d7e87248179c7c06f5d06a9ccf46c9964d9fd98 Author: Mark Cogan <marq@google.com> Date: Thu Apr 19 12:36:16 2018 [iOS] Trigger correct animation for new Tab grid cells. This CL tweaks how visible cells are detected so that the grid zoom animation is triggered when a new tab is created. The TabGridTransitionHandler chooses which animation to use for BVC presentation by checking to see if the selected grid cell is visible. This was handled by checking the collection view's selected cells. However, when a new cell is added, the selected cell in the collection view isn't updated until the completion block of the batchUpdates: call. The view controller presentation is started synchronously with the batchUpdates: invocation, so the visibility of the selected cell is determined before the completion block runs. The change this CL makes is to use the internal -selectedItemIndex to determine if the selected cell is visible. This is updated as part of the collection view updates, so it is accurate before the completion runs. Bug: 804586 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I54fe213847d1a7da8b0fcd019a848885f8dfe9ba Reviewed-on: https://chromium-review.googlesource.com/1016911 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#551992} [modify] https://crrev.com/6d7e87248179c7c06f5d06a9ccf46c9964d9fd98/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Apr 20 2018
,
Apr 24 2018
Issue 834978 has been merged into this issue.
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)