New issue
Advanced search Search tips

Issue 804581 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804571



Sign in to add a comment

Enable the segmented control to allow tapping it to switch tab grids.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Enable the segmented control to allow tapping it to switch tab grids.

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Incognito-Tab-Grid

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804571

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 23 2018

Labels: -Q1 Q2

Comment 7 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 8 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----

Comment 9 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 10 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 11 by marq@chromium.org, Mar 15 2018

Labels: -Q2 Q1
Status: Started (was: Available)

Comment 12 by marq@chromium.org, Mar 15 2018

NextAction: 2018-03-28

Comment 13 by marq@chromium.org, Mar 15 2018

Cc: -marq@chromium.org edchin@chromium.org
Owner: marq@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53bc613f93665b1c68d98cfd5f1a201dc5d7893

commit f53bc613f93665b1c68d98cfd5f1a201dc5d7893
Author: Mark Cogan <marq@google.com>
Date: Thu Mar 15 16:13:41 2018

[iOS] Page selection control for the tab grid.

This CL creates the custom selection control for the tab grid and
wires it into the TabGridViewController.

There are extensive comments in the TabGridPageSelector class.

Some things to note:

* Labels are used in place of assets for now.

* Dragging the slider in the control isn't possible yet.

* The view controller doesn't yet update the tab counts in the control.

Bug:  804500 ,  804581 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If561619091271b7086989f68bb76edb5bd64c16b
Reviewed-on: https://chromium-review.googlesource.com/962791
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543388}
[modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/BUILD.gn
[add] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.h
[add] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm
[modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.h
[modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 15 by marq@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment