New issue
Advanced search Search tips

Issue 804573 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804572

Blocking:
issue 804596



Sign in to add a comment

Create the incognito empty state promos.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Create the incognito empty state promos.


 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Incognito-Tab-Grid

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804572

Comment 5 by marq@chromium.org, Jan 23 2018

Blocking: 804596

Comment 6 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 7 by marq@chromium.org, Jan 23 2018

Labels: -Q1 Q2

Comment 8 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 9 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----
Labels: Q2

Comment 11 by cmasso@google.com, Jan 27 2018

Labels: -Q1
NextAction: 2018-03-14
Owner: edchin@chromium.org
Status: Started (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc724182d056a22d5b3869bcbb98828394f4af8d

commit cc724182d056a22d5b3869bcbb98828394f4af8d
Author: edchin <edchin@chromium.org>
Date: Thu Mar 08 17:15:06 2018

[ios] Grid empty states

This CL builds the basic logic and setup of the empty
states in the regular and incognito grids.

A future CL ( crbug.com/818198 ) will create a constants file
and consolidate/organize numbers as needed. This CL leaves
raw numbers in their place to minimize lookups while tweaking.

New raw strings will be internationalized through the process.

Bug:  804557 ,  804573 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I546e88e195e1273bc34c2f2e5d8c4c2f48930263
Reviewed-on: https://chromium-review.googlesource.com/954714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541816}
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.h
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 16 by cmasso@google.com, Mar 20 2018

NextAction: ----

Comment 17 by cmasso@google.com, Mar 20 2018

Labels: -Q2 Q1

Sign in to add a comment