New issue
Advanced search Search tips

Issue 804569 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 804567



Sign in to add a comment

Update EarlGrey tests to support undoing close-all-tabs

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Update Showcase and Showcase EarlGrey tests to support undoing close-all-tabs

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Undo-Close-All-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804498 804567

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 6 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 7 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----

Comment 8 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 9 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 10 by cmasso@google.com, Feb 20 2018

Blockedon: -804498
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 12 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-05-09
Status: Started (was: Assigned)
Summary: Update EarlGrey tests to support undoing close-all-tabs (was: Update Showcase and Showcase EarlGrey tests to support undoing close-all-tabs)
Project Member

Comment 17 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51af0d4a392a5c7bdaf715bdad4d5b2685075ecc

commit 51af0d4a392a5c7bdaf715bdad4d5b2685075ecc
Author: edchin <edchin@chromium.org>
Date: Mon May 07 16:57:32 2018

[ios] Add undo close all egtest

Previously, an alert was presented as a stub to the undo close all
action.

This CL updates the egtest to check that the undo operation actually
worked, now that the undo close all operation is fully implemented.
There already exists more extensive unittesting on the undo close all
operation.

Bug:  804569 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If30ec4fb457ccfad259f8b79a5a45e9db43a9a1e
Reviewed-on: https://chromium-review.googlesource.com/1045227
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556473}
[modify] https://crrev.com/51af0d4a392a5c7bdaf715bdad4d5b2685075ecc/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-09

Sign in to add a comment