New issue
Advanced search Search tips

Issue 804568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 804567



Sign in to add a comment

Implement the reverse animation. Lock scrolling while it is in progress.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Implement the reverse animation. Lock scrolling while it is in progress.

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Undo-Close-All-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804567

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 6 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 7 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----

Comment 8 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 9 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 11 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-05-23
Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f370ab2916f7e543d05c4629e7f1be7b5968933

commit 5f370ab2916f7e543d05c4629e7f1be7b5968933
Author: edchin <edchin@chromium.org>
Date: Wed May 16 05:32:41 2018

[ios] Animate Undo Close All

This CL adds an animation to
1) tabs when inserting them to the tab grid.
2) empty state view by fading it away.

These animations are not specifically for undo only, but rather for
whenever the tab grid goes from being empty to having a tab or tabs.

Video:
https://drive.google.com/open?id=17DgaYbJNAE3cjuW41TQ3Aafl6B-kxDU1

Bug:  804568 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I413cff014c2cbbfc243f9f37b424ccfd97a277d9
Reviewed-on: https://chromium-review.googlesource.com/1054628
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558989}
[modify] https://crrev.com/5f370ab2916f7e543d05c4629e7f1be7b5968933/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
[modify] https://crrev.com/5f370ab2916f7e543d05c4629e7f1be7b5968933/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-23

Sign in to add a comment