New issue
Advanced search Search tips

Issue 804567 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 804566

Blocking:
issue 804568
issue 804569



Sign in to add a comment

Enable the Undo control. Make it undo the Close All

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Enable the Undo control. Make it undo the Close All

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2 Type-Task
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Undo-Close-All-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804566

Comment 5 by marq@chromium.org, Jan 23 2018

Blocking: 804568

Comment 6 by marq@chromium.org, Jan 23 2018

Blocking: 804569

Comment 7 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 8 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 9 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----
Labels: Q2

Comment 11 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 13 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Status: Started (was: Assigned)
NextAction: 2018-05-09
Labels: -medium large
This was originally a medium, but I did a lot of thinking around this, and there are some tricky parts to making this feature work. I assess that it is a large task. 
Project Member

Comment 20 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a943faef14c2772d5b304e888098ac7f35fa99

commit f0a943faef14c2772d5b304e888098ac7f35fa99
Author: edchin <edchin@chromium.org>
Date: Wed May 02 21:05:07 2018

[ios] Enable undo close all tabs

This CL enables undo close all tabs in the tab grid by serializing
the current window. The undo operation deserializes the saved closed
window.

Current known issue is that snapshots are erased when WebStates are
closed. Another CL will deal with keeping snapshots around long enough
for undo operations.

Bug:  804567 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I12cf8c11d1e067a7de1b9a6ce44d207810619eb8
Reviewed-on: https://chromium-review.googlesource.com/1036257
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555520}
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/ui/tab_grid/grid/grid_commands.h
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/ui/tab_grid/tab_grid_mediator_unittest.mm
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm
[modify] https://crrev.com/f0a943faef14c2772d5b304e888098ac7f35fa99/ios/web/public/test/fakes/test_web_state.mm

Project Member

Comment 21 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ab3fe6bfcec219fad4e0f48bdd03c03c31281c

commit 45ab3fe6bfcec219fad4e0f48bdd03c03c31281c
Author: edchin <edchin@chromium.org>
Date: Fri May 04 19:56:56 2018

[ios] Restore snapshot for undo close all tabs

When closing tabs, an observer immediately deletes snapshots from the
snapshot cache. This prevents snapshots from reappearing in an undo
close all tabs operation.

This CL enables snapshot restoration on undo close all tabs by extending
the life of a snapshot when closed with a "close all" operation. Note
this is only extended for regular tabs, not incognito tabs.

The extended life is accomplished by marking tabs for deletion during
a close all operation, rather than immediately deleting the image
from the cache. Later, the marked images are either purged from the
cache, or the marked list is cleared (therefore leaving the images in
the cache).

Bug:  804567 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4710bf46d3ebd4ad347563e5f6a6208a68a58209
Reviewed-on: https://chromium-review.googlesource.com/1041545
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556162}
[modify] https://crrev.com/45ab3fe6bfcec219fad4e0f48bdd03c03c31281c/ios/chrome/browser/snapshots/snapshot_cache.h
[modify] https://crrev.com/45ab3fe6bfcec219fad4e0f48bdd03c03c31281c/ios/chrome/browser/snapshots/snapshot_cache.mm
[modify] https://crrev.com/45ab3fe6bfcec219fad4e0f48bdd03c03c31281c/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm
[modify] https://crrev.com/45ab3fe6bfcec219fad4e0f48bdd03c03c31281c/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-09
Status: Verified (was: Fixed)
Verified in 68.0.3431.0 Canary, iPhone X iOS 11.4 beta 4, iPhone 6 iOS 10.3.3
Undo for Close All is Enabled.

Sign in to add a comment